-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Infra UI] Centralize chart components (#163283)
closes [#161957](#161957) ## Summary This PR encapsulates the styling and logic to render the Lens charts components. Doing so simplifies the usage in places that render these charts, eliminating the previously necessary code duplication ### How to test - Start a local Kibana instance - Navigate to `Infrastructure` > `Hosts` - Confirm that all charts still work - Play with the filters - Verify whether only charts above the fold are rendered - Open the flyout - Switch hosts with the flyout open --------- Co-authored-by: Kibana Machine <[email protected]>
- Loading branch information
1 parent
143355a
commit c04f566
Showing
24 changed files
with
472 additions
and
593 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
x-pack/plugins/infra/public/components/asset_details/constants.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
export const METRIC_CHART_HEIGHT = 300; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
124 changes: 0 additions & 124 deletions
124
x-pack/plugins/infra/public/components/asset_details/tabs/overview/kpis/tile.tsx
This file was deleted.
Oops, something went wrong.
116 changes: 0 additions & 116 deletions
116
x-pack/plugins/infra/public/components/asset_details/tabs/overview/metrics/metric_chart.tsx
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.