From bae5b6f901fe9acca6ca11f59d7674d83efe697b Mon Sep 17 00:00:00 2001 From: restrry Date: Fri, 31 Jan 2020 14:41:59 +0100 Subject: [PATCH] improve names --- .../legacy/integration_tests/logging.test.ts | 18 +++++++++--------- .../server/logging/integration_tests/utils.ts | 8 ++++---- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/src/core/server/legacy/integration_tests/logging.test.ts b/src/core/server/legacy/integration_tests/logging.test.ts index 6cf7ba1d35686..1923ed2866cde 100644 --- a/src/core/server/legacy/integration_tests/logging.test.ts +++ b/src/core/server/legacy/integration_tests/logging.test.ts @@ -19,8 +19,8 @@ import * as kbnTestServer from '../../../../test_utils/kbn_server'; import { - getPlatformLoggingFromMock, - getLegacyPlatformLoggingFromMock, + getPlatformLogsFromMock, + getLegacyPlatformLogsFromMock, } from '../../logging/integration_tests/utils'; import { LegacyLoggingConfig } from '../config/legacy_object_to_config_adapter'; @@ -93,7 +93,7 @@ describe('logging service', () => { root.logger.get('test-file').info('handled by NP'); expect(mockConsoleLog).toHaveBeenCalledTimes(1); - const loggedString = getPlatformLoggingFromMock(mockConsoleLog); + const loggedString = getPlatformLogsFromMock(mockConsoleLog); expect(loggedString).toMatchInlineSnapshot(` Array [ "[xxxx-xx-xxTxx:xx:xx.xxxZ][INFO ][test-file] handled by NP", @@ -106,7 +106,7 @@ describe('logging service', () => { expect(mockStdout).toHaveBeenCalledTimes(1); - const loggedString = getLegacyPlatformLoggingFromMock(mockStdout); + const loggedString = getLegacyPlatformLogsFromMock(mockStdout); expect(loggedString).toMatchInlineSnapshot(` Array [ " log [xx:xx:xx.xxx] [info][test-file-legacy] handled by LP @@ -138,7 +138,7 @@ describe('logging service', () => { expect(mockConsoleLog).toHaveBeenCalledTimes(3); - expect(getPlatformLoggingFromMock(mockConsoleLog)).toMatchInlineSnapshot(` + expect(getPlatformLogsFromMock(mockConsoleLog)).toMatchInlineSnapshot(` Array [ "[xxxx-xx-xxTxx:xx:xx.xxxZ][INFO ][test-file] info", "[xxxx-xx-xxTxx:xx:xx.xxxZ][WARN ][test-file] warn", @@ -169,7 +169,7 @@ describe('logging service', () => { expect(mockConsoleLog).toHaveBeenCalledTimes(3); - expect(getPlatformLoggingFromMock(mockConsoleLog)).toMatchInlineSnapshot(` + expect(getPlatformLogsFromMock(mockConsoleLog)).toMatchInlineSnapshot(` Array [ "[xxxx-xx-xxTxx:xx:xx.xxxZ][INFO ][test-file] info", "[xxxx-xx-xxTxx:xx:xx.xxxZ][WARN ][test-file] warn", @@ -185,7 +185,7 @@ describe('logging service', () => { legacyPlatformLogger.error('error'); expect(mockStdout).toHaveBeenCalledTimes(1); - expect(getLegacyPlatformLoggingFromMock(mockStdout)).toMatchInlineSnapshot(` + expect(getLegacyPlatformLogsFromMock(mockStdout)).toMatchInlineSnapshot(` Array [ " log [xx:xx:xx.xxx] [error][test-file-legacy] error ", @@ -206,7 +206,7 @@ describe('logging service', () => { expect(mockConsoleLog).toHaveBeenCalledTimes(3); - expect(getPlatformLoggingFromMock(mockConsoleLog)).toMatchInlineSnapshot(` + expect(getPlatformLogsFromMock(mockConsoleLog)).toMatchInlineSnapshot(` Array [ "[xxxx-xx-xxTxx:xx:xx.xxxZ][INFO ][test-file] info", "[xxxx-xx-xxTxx:xx:xx.xxxZ][WARN ][test-file] warn", @@ -222,7 +222,7 @@ describe('logging service', () => { legacyPlatformLogger.error('error'); expect(mockStdout).toHaveBeenCalledTimes(3); - expect(getLegacyPlatformLoggingFromMock(mockStdout)).toMatchInlineSnapshot(` + expect(getLegacyPlatformLogsFromMock(mockStdout)).toMatchInlineSnapshot(` Array [ " log [xx:xx:xx.xxx] [info][test-file-legacy] info ", diff --git a/src/core/server/logging/integration_tests/utils.ts b/src/core/server/logging/integration_tests/utils.ts index c81b96763c879..81a76ce76ad73 100644 --- a/src/core/server/logging/integration_tests/utils.ts +++ b/src/core/server/logging/integration_tests/utils.ts @@ -40,18 +40,18 @@ function normalizeLegacyPlatformLogging(input: string) { return replaceTimestamp(stripColors(input)); } -export function getPlatformLoggingFromMock(logMock: jest.SpyInstance) { +export function getPlatformLogsFromMock(logMock: jest.SpyInstance) { return logMock.mock.calls.map(([message]) => message).map(normalizePlatformLogging); } -export function getLegacyPlatformLoggingFromMock(stdoutMock: jest.SpyInstance) { +export function getLegacyPlatformLogsFromMock(stdoutMock: jest.SpyInstance) { return stdoutMock.mock.calls .map(([message]) => message) .map(String) .map(normalizeLegacyPlatformLogging); } -export async function getPlatformLoggingContent(path: string) { +export async function getPlatformLogsFromFile(path: string) { const fileContent = await readFile(path, 'utf-8'); return fileContent .split('\n') @@ -59,7 +59,7 @@ export async function getPlatformLoggingContent(path: string) { .join('\n'); } -export async function getLegacyPlatformLoggingContent(path: string) { +export async function getLegacyPlatformLogsFromFile(path: string) { const fileContent = await readFile(path, 'utf-8'); return fileContent .split('\n')