From e61120b038d5999ef3c77a062317e50f12576245 Mon Sep 17 00:00:00 2001 From: Scotty Bollinger Date: Wed, 16 Sep 2020 13:08:28 -0500 Subject: [PATCH 001/168] [Enterprise Search] Update layout for white bg (#77555) * [Enterprise Search] Update layout for white bg This PR updates the Enterprise Search layout to have a white background. Includes: - Updating the header hights to account for search bar (renamed from kibana to console for future proofing) - Add height to extend to bottom of page - Change bg to white * D R Y * Update x-pack/plugins/enterprise_search/public/applications/shared/layout/layout.scss Thanks! Co-authored-by: Constance Co-authored-by: Constance Co-authored-by: Elastic Machine --- .../public/applications/shared/layout/layout.scss | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/x-pack/plugins/enterprise_search/public/applications/shared/layout/layout.scss b/x-pack/plugins/enterprise_search/public/applications/shared/layout/layout.scss index c73a527147961..f6c83888413d3 100644 --- a/x-pack/plugins/enterprise_search/public/applications/shared/layout/layout.scss +++ b/x-pack/plugins/enterprise_search/public/applications/shared/layout/layout.scss @@ -7,8 +7,12 @@ .enterpriseSearchLayout { $sideBarWidth: $euiSize * 15; $sideBarMobileHeight: $euiSize * 4.75; + $consoleHeaderHeight: 98px; // NOTE: Keep an eye on this for changes + $pageHeight: calc(100vh - #{$consoleHeaderHeight}); display: block; + background-color: $euiColorEmptyShade; + min-height: $pageHeight; position: relative; left: $sideBarWidth; width: calc(100% - #{$sideBarWidth}); @@ -44,8 +48,7 @@ overflow-y: auto; overflow-x: hidden; - $kibanaHeader: 49px; // NOTE: Keep an eye on this for changes - height: calc(100vh - #{$kibanaHeader}); + height: $pageHeight; width: $sideBarWidth; background-color: $euiColorLightestShade; From e5b302eeee4d7a9331c56c5ae93f7e8603603754 Mon Sep 17 00:00:00 2001 From: Greg Thompson Date: Wed, 16 Sep 2020 12:10:10 -0600 Subject: [PATCH 002/168] Upgrade EUI to v28.4.0 (#77098) * eui to 28.4.0 * euiselectableoption fixes * src snapshot updates * x-pack snapshot updates * htmlidgenerator mock * merge resolution * clean up * snapshot update * prevent api changes --- package.json | 2 +- packages/kbn-ui-shared-deps/package.json | 2 +- .../collapsible_nav.test.tsx.snap | 6 ++ .../header/__snapshots__/header.test.tsx.snap | 1 + .../__snapshots__/new_vis_modal.test.tsx.snap | 8 +- .../plugins/kbn_tp_run_pipeline/package.json | 2 +- .../kbn_sample_panel_action/package.json | 2 +- .../kbn_tp_custom_visualizations/package.json | 2 +- x-pack/package.json | 2 +- .../Stacktrace/__test__/Stackframe.test.tsx | 6 ++ .../__snapshots__/Stackframe.test.tsx.snap | 1 + .../__snapshots__/palette.stories.storyshot | 2 - .../font_picker.stories.storyshot | 4 - .../palette_picker.stories.storyshot | 6 -- .../saved_elements_modal.stories.storyshot | 6 +- .../text_style_picker.stories.storyshot | 4 - .../__snapshots__/edit_var.stories.storyshot | 8 -- .../var_config.stories.storyshot | 1 + .../workpad_templates.stories.storyshot | 2 +- .../extended_template.stories.storyshot | 6 -- .../addon/src/components/action_list.tsx | 5 +- .../__snapshots__/search_bar.test.tsx.snap | 2 +- .../add_tooltip_field_popover.tsx | 12 ++- .../__snapshots__/index.test.tsx.snap | 2 + .../note_card_body.test.tsx.snap | 2 + .../__snapshots__/cert_search.test.tsx.snap | 2 +- yarn.lock | 73 ++++++++++--------- 27 files changed, 82 insertions(+), 89 deletions(-) diff --git a/package.json b/package.json index c990c8bc9081c..1395050263fd6 100644 --- a/package.json +++ b/package.json @@ -128,7 +128,7 @@ "@babel/register": "^7.10.5", "@elastic/datemath": "5.0.3", "@elastic/elasticsearch": "7.9.0-rc.2", - "@elastic/eui": "28.2.0", + "@elastic/eui": "28.4.0", "@elastic/good": "8.1.1-kibana2", "@elastic/numeral": "^2.5.0", "@elastic/request-crypto": "1.1.4", diff --git a/packages/kbn-ui-shared-deps/package.json b/packages/kbn-ui-shared-deps/package.json index bbe7b1bc2e8da..8095e05e8b855 100644 --- a/packages/kbn-ui-shared-deps/package.json +++ b/packages/kbn-ui-shared-deps/package.json @@ -10,7 +10,7 @@ }, "dependencies": { "@elastic/charts": "21.1.2", - "@elastic/eui": "28.2.0", + "@elastic/eui": "28.4.0", "@elastic/numeral": "^2.5.0", "@kbn/i18n": "1.0.0", "@kbn/monaco": "1.0.0", diff --git a/src/core/public/chrome/ui/header/__snapshots__/collapsible_nav.test.tsx.snap b/src/core/public/chrome/ui/header/__snapshots__/collapsible_nav.test.tsx.snap index 1bff6cd9301ed..699fe2c4c4d4d 100644 --- a/src/core/public/chrome/ui/header/__snapshots__/collapsible_nav.test.tsx.snap +++ b/src/core/public/chrome/ui/header/__snapshots__/collapsible_nav.test.tsx.snap @@ -658,6 +658,7 @@ exports[`CollapsibleNav renders links grouped by category 1`] = ` aria-controls="mockId" aria-expanded={true} className="euiAccordion__button euiAccordion__buttonReverse euiCollapsibleNavGroup__heading" + id="mockId" onClick={[Function]} type="button" > @@ -911,6 +912,7 @@ exports[`CollapsibleNav renders links grouped by category 1`] = ` aria-controls="mockId" aria-expanded={true} className="euiAccordion__button euiAccordion__buttonReverse euiCollapsibleNavGroup__heading" + id="mockId" onClick={[Function]} type="button" > @@ -1200,6 +1202,7 @@ exports[`CollapsibleNav renders links grouped by category 1`] = ` aria-controls="mockId" aria-expanded={true} className="euiAccordion__button euiAccordion__buttonReverse euiCollapsibleNavGroup__heading" + id="mockId" onClick={[Function]} type="button" > @@ -1450,6 +1453,7 @@ exports[`CollapsibleNav renders links grouped by category 1`] = ` aria-controls="mockId" aria-expanded={true} className="euiAccordion__button euiAccordion__buttonReverse euiCollapsibleNavGroup__heading" + id="mockId" onClick={[Function]} type="button" > @@ -1652,6 +1656,7 @@ exports[`CollapsibleNav renders links grouped by category 1`] = ` aria-controls="mockId" aria-expanded={true} className="euiAccordion__button euiAccordion__buttonReverse euiCollapsibleNavGroup__heading" + id="mockId" onClick={[Function]} type="button" > @@ -2875,6 +2880,7 @@ exports[`CollapsibleNav renders the default nav 3`] = ` aria-controls="mockId" aria-expanded={true} className="euiAccordion__button euiAccordion__buttonReverse euiCollapsibleNavGroup__heading" + id="mockId" onClick={[Function]} type="button" > diff --git a/src/core/public/chrome/ui/header/__snapshots__/header.test.tsx.snap b/src/core/public/chrome/ui/header/__snapshots__/header.test.tsx.snap index d90d0824a1237..b5c1f3ca843e4 100644 --- a/src/core/public/chrome/ui/header/__snapshots__/header.test.tsx.snap +++ b/src/core/public/chrome/ui/header/__snapshots__/header.test.tsx.snap @@ -5734,6 +5734,7 @@ exports[`Header renders 1`] = ` aria-controls="mockId" aria-expanded={true} className="euiAccordion__button euiAccordion__buttonReverse euiCollapsibleNavGroup__heading" + id="mockId" onClick={[Function]} type="button" > diff --git a/src/plugins/visualizations/public/wizard/__snapshots__/new_vis_modal.test.tsx.snap b/src/plugins/visualizations/public/wizard/__snapshots__/new_vis_modal.test.tsx.snap index 3c4c983efa9fa..0925d1c7cc0c9 100644 --- a/src/plugins/visualizations/public/wizard/__snapshots__/new_vis_modal.test.tsx.snap +++ b/src/plugins/visualizations/public/wizard/__snapshots__/new_vis_modal.test.tsx.snap @@ -196,7 +196,7 @@ exports[`NewVisModal filter for visualization types should render as expected 1` > { + return { + htmlIdGenerator: () => () => `generated-id`, + }; +}); + describe('Stackframe', () => { describe('when stackframe has source lines', () => { let wrapper: ReactWrapper; diff --git a/x-pack/plugins/apm/public/components/shared/Stacktrace/__test__/__snapshots__/Stackframe.test.tsx.snap b/x-pack/plugins/apm/public/components/shared/Stacktrace/__test__/__snapshots__/Stackframe.test.tsx.snap index f87cc62d7809d..a5f8c40876540 100644 --- a/x-pack/plugins/apm/public/components/shared/Stacktrace/__test__/__snapshots__/Stackframe.test.tsx.snap +++ b/x-pack/plugins/apm/public/components/shared/Stacktrace/__test__/__snapshots__/Stackframe.test.tsx.snap @@ -177,6 +177,7 @@ exports[`Stackframe when stackframe has source lines should render correctly 1`] aria-controls="test" aria-expanded={false} className="euiAccordion__button" + id="generated-id" onClick={[Function]} type="button" > diff --git a/x-pack/plugins/canvas/canvas_plugin_src/uis/arguments/__stories__/__snapshots__/palette.stories.storyshot b/x-pack/plugins/canvas/canvas_plugin_src/uis/arguments/__stories__/__snapshots__/palette.stories.storyshot index 385b16d3d8e8e..c0d3256eb9eb7 100644 --- a/x-pack/plugins/canvas/canvas_plugin_src/uis/arguments/__stories__/__snapshots__/palette.stories.storyshot +++ b/x-pack/plugins/canvas/canvas_plugin_src/uis/arguments/__stories__/__snapshots__/palette.stories.storyshot @@ -48,12 +48,10 @@ exports[`Storyshots arguments/Palette default 1`] = ` + + + +
+ + +
+
+
+
+
+
+
+
+
+
+
+ + + + + + + + + + + + + + +
+
+
+ + Name + +
+
+
+ + OS + +
+
+
+ + Date Created + +
+
+
+ + Created By + +
+
+
+ + No items found + +
+
+
+
+
+
+
+ , + "container":
+
+
+
+
+

+ Trusted Applications + + + Beta + +

+
+
+ View and configure trusted applications +
+
+
+
+ +
+
+
+
+ + +
+
+
+
+
+
+
+
+
+
+
+ + + + + + + + + + + + + + +
+
+
+ + Name + +
+
+
+ + OS + +
+
+
+ + Date Created + +
+
+
+ + Created By + +
+
+
+ + No items found + +
+
+
+
+
+
+
, + "debug": [Function], + "findAllByAltText": [Function], + "findAllByDisplayValue": [Function], + "findAllByLabelText": [Function], + "findAllByPlaceholderText": [Function], + "findAllByRole": [Function], + "findAllByTestId": [Function], + "findAllByText": [Function], + "findAllByTitle": [Function], + "findByAltText": [Function], + "findByDisplayValue": [Function], + "findByLabelText": [Function], + "findByPlaceholderText": [Function], + "findByRole": [Function], + "findByTestId": [Function], + "findByText": [Function], + "findByTitle": [Function], + "getAllByAltText": [Function], + "getAllByDisplayValue": [Function], + "getAllByLabelText": [Function], + "getAllByPlaceholderText": [Function], + "getAllByRole": [Function], + "getAllByTestId": [Function], + "getAllByText": [Function], + "getAllByTitle": [Function], + "getByAltText": [Function], + "getByDisplayValue": [Function], + "getByLabelText": [Function], + "getByPlaceholderText": [Function], + "getByRole": [Function], + "getByTestId": [Function], + "getByText": [Function], + "getByTitle": [Function], + "queryAllByAltText": [Function], + "queryAllByDisplayValue": [Function], + "queryAllByLabelText": [Function], + "queryAllByPlaceholderText": [Function], + "queryAllByRole": [Function], + "queryAllByTestId": [Function], + "queryAllByText": [Function], + "queryAllByTitle": [Function], + "queryByAltText": [Function], + "queryByDisplayValue": [Function], + "queryByLabelText": [Function], + "queryByPlaceholderText": [Function], + "queryByRole": [Function], + "queryByTestId": [Function], + "queryByText": [Function], + "queryByTitle": [Function], + "rerender": [Function], + "unmount": [Function], +} +`; + +exports[`TrustedAppsPage when the Add Trusted App button is clicked should display create form 1`] = ` +@media only screen and (min-width:575px) { + +} + +
- - +
+
+ +
+
+
+
+ +
+
+
+
+
+
+ +
+
+
+
+ +
+
+ + Select an option: Windows, is selected + + +
+ + +
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ +
+
+
+
+ +
+
+ + Select an option: Hash, is selected + + +
+ + +
+
+
+
+
+
+
+
+
+
+ +
+
+
+
+ +
+
+
+
+
+
+
+
+ +
+
+
+
+ +
+
+
+
+
+
+
+
+ +
+
+ +
+
+
+
+
+
+
+
+ +
+
+
+
+
+ +
+
+