cr

elastic · Aug 30, 2023 · 97f17f9 · 97f17f9
1 parent 4d6f732
commit 97f17f9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 13 deletions.
diff --git a/.../security_solution/server/lib/detection_engine/routes/signals/open_close_signals_route.ts b/.../security_solution/server/lib/detection_engine/routes/signals/open_close_signals_route.ts
@@ -123,11 +123,7 @@ const updateSignalsStatusByIds = async (
 ) =>
   esClient.updateByQuery({
     index: `${DEFAULT_ALERTS_INDEX}-${spaceId}`,
-    // conflicts: options.conflicts,
-    // https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-update-by-query.html#_refreshing_shards_2
-    // Note: Before we tried to use "refresh: wait_for" but I do not think that was available and instead it defaulted to "refresh: true"
-    // but the tests do not pass with "refresh: false". If at some point a "refresh: wait_for" is implemented, we should use that instead.
-    refresh: true,
+    refresh: false,
     body: {
       script: getUpdateSignalStatusScript(status),
       query: {
@@ -154,10 +150,7 @@ const updateSignalsStatusByQuery = async (
   esClient.updateByQuery({
     index: `${DEFAULT_ALERTS_INDEX}-${spaceId}`,
     conflicts: options.conflicts,
-    // https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-update-by-query.html#_refreshing_shards_2
-    // Note: Before we tried to use "refresh: wait_for" but I do not think that was available and instead it defaulted to "refresh: true"
-    // but the tests do not pass with "refresh: false". If at some point a "refresh: wait_for" is implemented, we should use that instead.
-    refresh: true,
+    refresh: false,
     body: {
       script: getUpdateSignalStatusScript(status),
       query: {

diff --git a/...gins/security_solution/server/lib/detection_engine/routes/signals/set_alert_tags_route.ts b/...gins/security_solution/server/lib/detection_engine/routes/signals/set_alert_tags_route.ts
@@ -92,10 +92,7 @@ export const setAlertTagsRoute = (router: SecuritySolutionPluginRouter) => {
       try {
         const body = await esClient.updateByQuery({
           index: `${DEFAULT_ALERTS_INDEX}-${spaceId}`,
-          // https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-update-by-query.html#_refreshing_shards_2
-          // Note: Before we tried to use "refresh: wait_for" but I do not think that was available and instead it defaulted to "refresh: true"
-          // but the tests do not pass with "refresh: false". If at some point a "refresh: wait_for" is implemented, we should use that instead.
-          refresh: true,
+          refresh: false,
           body: {
             script: painlessScript,
             query: {