From 9527a8f2cafdc9723de489f90bf64331679db2f3 Mon Sep 17 00:00:00 2001 From: Spencer Date: Wed, 23 Nov 2016 15:03:47 -0700 Subject: [PATCH] `render-counter` directive (#9206) * [docTable/row] delay first render until watchers initialize * [docTable/row] emit a renderComplete event, count in table directive * [renderCounter] unify render counting login into directive * [docTable] remove unused var --- .../dashboard/components/panel/panel.html | 5 ++- .../kibana/public/discover/index.html | 3 +- .../public/visualize/editor/editor.html | 1 + src/ui/public/directives/render_counter.js | 31 +++++++++++++++++++ .../public/doc_table/components/table_row.js | 17 ++++------ src/ui/public/doc_table/doc_table.html | 2 +- src/ui/public/visualize/visualize.js | 13 +++----- 7 files changed, 49 insertions(+), 23 deletions(-) create mode 100644 src/ui/public/directives/render_counter.js diff --git a/src/core_plugins/kibana/public/dashboard/components/panel/panel.html b/src/core_plugins/kibana/public/dashboard/components/panel/panel.html index 6665034471980..874a62b75522a 100644 --- a/src/core_plugins/kibana/public/dashboard/components/panel/panel.html +++ b/src/core_plugins/kibana/public/dashboard/components/panel/panel.html @@ -28,13 +28,16 @@ search-source="savedObj.searchSource" show-spy-panel="chrome.getVisible()" ui-state="uiState" + render-counter class="panel-content"> - diff --git a/src/core_plugins/kibana/public/discover/index.html b/src/core_plugins/kibana/public/discover/index.html index 1a60d56b6b641..0f2faa466bc67 100644 --- a/src/core_plugins/kibana/public/discover/index.html +++ b/src/core_plugins/kibana/public/discover/index.html @@ -125,7 +125,8 @@

Searching

sorting="state.sort" columns="state.columns" infinite-scroll="true" - filter="filterQuery"> + filter="filterQuery" + render-counter>
diff --git a/src/core_plugins/kibana/public/visualize/editor/editor.html b/src/core_plugins/kibana/public/visualize/editor/editor.html index f0547cbe8e87a..44d62bb5a3fc2 100644 --- a/src/core_plugins/kibana/public/visualize/editor/editor.html +++ b/src/core_plugins/kibana/public/visualize/editor/editor.html @@ -80,6 +80,7 @@
({ + controller($scope, $element) { + let counter = 0; + + const increment = () => { + counter += 1; + $element.attr('render-counter', counter); + }; + + const teardown = () => { + $element.off('renderComplete', increment); + }; + + const setup = () => { + $element.attr('render-counter', counter); + $element.on('renderComplete', increment); + $scope.$on('$destroy', teardown); + }; + + this.disable = () => { + $element.attr('render-counter', 'disabled'); + teardown(); + }; + + setup(); + } + })); diff --git a/src/ui/public/doc_table/components/table_row.js b/src/ui/public/doc_table/components/table_row.js index 530ddb996c3a9..c8cab43acb329 100644 --- a/src/ui/public/doc_table/components/table_row.js +++ b/src/ui/public/doc_table/components/table_row.js @@ -40,10 +40,6 @@ module.directive('kbnTableRow', function ($compile) { $el.after(''); $el.empty(); - let init = function () { - createSummaryRow($scope.row, $scope.row._id); - }; - // when we compile the details, we use this $scope let $detailsScope; @@ -79,11 +75,11 @@ module.directive('kbnTableRow', function ($compile) { $compile($detailsTr)($detailsScope); }; - $scope.$watchCollection('columns', function () { - createSummaryRow($scope.row, $scope.row._id); - }); - - $scope.$watchMulti(['indexPattern.timeFieldName', 'row.highlight'], function () { + $scope.$watchMulti([ + 'indexPattern.timeFieldName', + 'row.highlight', + '[]columns' + ], function () { createSummaryRow($scope.row, $scope.row._id); }); @@ -144,6 +140,7 @@ module.directive('kbnTableRow', function ($compile) { // trim off cells that were not used rest of the cells $cells.filter(':gt(' + (newHtmls.length - 1) + ')').remove(); + $el.trigger('renderComplete'); } /** @@ -161,8 +158,6 @@ module.directive('kbnTableRow', function ($compile) { return text; } - - init(); } }; }); diff --git a/src/ui/public/doc_table/doc_table.html b/src/ui/public/doc_table/doc_table.html index 68cd1e0c3d4f2..1f7f0c0c90ce0 100644 --- a/src/ui/public/doc_table/doc_table.html +++ b/src/ui/public/doc_table/doc_table.html @@ -43,4 +43,4 @@

No results found

-
\ No newline at end of file +
diff --git a/src/ui/public/visualize/visualize.js b/src/ui/public/visualize/visualize.js index 29234e2b46cbf..39e9885bc5eb7 100644 --- a/src/ui/public/visualize/visualize.js +++ b/src/ui/public/visualize/visualize.js @@ -25,6 +25,7 @@ uiModules return { restrict: 'E', + require: '?renderCounter', scope : { showSpyPanel: '=?', vis: '=', @@ -34,7 +35,7 @@ uiModules esResp: '=?', }, template: visualizeTemplate, - link: function ($scope, $el, attr) { + link: function ($scope, $el, attr, renderCounter) { const minVisChartHeight = 180; if (_.isUndefined($scope.showSpyPanel)) { @@ -72,14 +73,8 @@ uiModules return legendPositionToVisContainerClassMap[$scope.vis.params.legendPosition]; }; - if ($scope.vis.implementsRenderComplete()) { - $el.attr('has-render-count', 'true'); - let renderCount = 0; - $el.on('renderComplete', () => { - $el.attr('render-count', ++renderCount); - }); - } else { - $el.attr('has-render-count', 'false'); + if (renderCounter && !$scope.vis.implementsRenderComplete()) { + renderCounter.disable(); } $scope.spy = {};