From 90666e79ce48d983e981e6b7769ffc6b29c48d9e Mon Sep 17 00:00:00 2001
From: pgayvallet <pierre.gayvallet@gmail.com>
Date: Tue, 14 Sep 2021 16:12:13 +0200
Subject: [PATCH] remove last usages of plugin async lifecycles

---
 src/plugins/presentation_util/README.mdx            |  2 +-
 x-pack/plugins/lists/server/plugin.ts               |  2 +-
 x-pack/plugins/monitoring/server/plugin.ts          |  2 +-
 .../plugins/kibana_cors_test/server/plugin.ts       | 13 ++++++-------
 .../plugins/application_usage_test/public/plugin.ts | 10 +++++++---
 5 files changed, 16 insertions(+), 13 deletions(-)

diff --git a/src/plugins/presentation_util/README.mdx b/src/plugins/presentation_util/README.mdx
index 35b80e3634534..575e8002e6eb8 100755
--- a/src/plugins/presentation_util/README.mdx
+++ b/src/plugins/presentation_util/README.mdx
@@ -162,7 +162,7 @@ Once your services and providers are defined, and you have at least one set of f
 import { pluginServices } from './services';
 import { registry } from './services/kibana';
 
-  public async start(
+  public start(
     coreStart: CoreStart,
     startPlugins: StartDeps
   ): Promise<PresentationUtilPluginStart> {
diff --git a/x-pack/plugins/lists/server/plugin.ts b/x-pack/plugins/lists/server/plugin.ts
index 004677852d020..54d9d033ab1d4 100644
--- a/x-pack/plugins/lists/server/plugin.ts
+++ b/x-pack/plugins/lists/server/plugin.ts
@@ -39,7 +39,7 @@ export class ListPlugin
     this.config = this.initializerContext.config.get<ConfigType>();
   }
 
-  public async setup(core: CoreSetup): Promise<ListPluginSetup> {
+  public setup(core: CoreSetup): Promise<ListPluginSetup> {
     const { config } = this;
 
     initSavedObjects(core.savedObjects);
diff --git a/x-pack/plugins/monitoring/server/plugin.ts b/x-pack/plugins/monitoring/server/plugin.ts
index 1d6af9f080dc0..7e2d7c13b665e 100644
--- a/x-pack/plugins/monitoring/server/plugin.ts
+++ b/x-pack/plugins/monitoring/server/plugin.ts
@@ -206,7 +206,7 @@ export class MonitoringPlugin
     }
   }
 
-  async start(coreStart: CoreStart, { licensing }: PluginsStart) {
+  start(coreStart: CoreStart, { licensing }: PluginsStart) {
     const config = this.config!;
     this.cluster = instantiateClient(
       config.ui.elasticsearch,
diff --git a/x-pack/test/functional_cors/plugins/kibana_cors_test/server/plugin.ts b/x-pack/test/functional_cors/plugins/kibana_cors_test/server/plugin.ts
index e6c3f4b05aabd..56397336a371d 100644
--- a/x-pack/test/functional_cors/plugins/kibana_cors_test/server/plugin.ts
+++ b/x-pack/test/functional_cors/plugins/kibana_cors_test/server/plugin.ts
@@ -47,20 +47,18 @@ fetch('${url}', {
 
 export class CorsTestPlugin implements Plugin {
   private server?: Hapi.Server;
+
   constructor(private readonly initializerContext: PluginInitializerContext) {}
 
-  async setup(core: CoreSetup) {
+  setup(core: CoreSetup) {
     const router = core.http.createRouter();
     router.post({ path: '/cors-test', validate: false }, (context, req, res) =>
       res.ok({ body: 'content from kibana' })
     );
   }
 
-  async start(core: CoreStart) {
-    const config = await this.initializerContext.config
-      .create<ConfigSchema>()
-      .pipe(take(1))
-      .toPromise();
+  start(core: CoreStart) {
+    const config = this.initializerContext.config.get<ConfigSchema>();
 
     const server = new Hapi.Server({
       port: config.port,
@@ -78,8 +76,9 @@ export class CorsTestPlugin implements Plugin {
         return h.response(renderBody(kibanaUrl));
       },
     });
-    await server.start();
+    server.start();
   }
+
   public stop() {
     if (this.server) {
       this.server.stop();
diff --git a/x-pack/test/usage_collection/plugins/application_usage_test/public/plugin.ts b/x-pack/test/usage_collection/plugins/application_usage_test/public/plugin.ts
index b0c777593b021..ff1e89b58c7e8 100644
--- a/x-pack/test/usage_collection/plugins/application_usage_test/public/plugin.ts
+++ b/x-pack/test/usage_collection/plugins/application_usage_test/public/plugin.ts
@@ -12,8 +12,12 @@ import './types';
 export class ApplicationUsageTest implements Plugin {
   public setup(core: CoreSetup) {}
 
-  public async start(core: CoreStart) {
-    const applications = await core.application.applications$.pipe(first()).toPromise();
-    window.__applicationIds__ = [...applications.keys()];
+  public start(core: CoreStart) {
+    core.application.applications$
+      .pipe(first())
+      .toPromise()
+      .then((applications) => {
+        window.__applicationIds__ = [...applications.keys()];
+      });
   }
 }