From 8f55489ff6c255189a14808e4a0abab2e0f10f8b Mon Sep 17 00:00:00 2001 From: Giorgos Bamparopoulos Date: Mon, 6 Dec 2021 13:53:20 +0200 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Casper Hübertz --- .../app/Settings/agent_keys/create_agent_key.tsx | 6 +++--- .../agent_keys/create_agent_key/agent_key_callout.tsx | 2 +- .../public/components/app/Settings/agent_keys/index.tsx | 8 ++++---- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/x-pack/plugins/apm/public/components/app/Settings/agent_keys/create_agent_key.tsx b/x-pack/plugins/apm/public/components/app/Settings/agent_keys/create_agent_key.tsx index e7fcefc62ac80..87b65462436ed 100644 --- a/x-pack/plugins/apm/public/components/app/Settings/agent_keys/create_agent_key.tsx +++ b/x-pack/plugins/apm/public/components/app/Settings/agent_keys/create_agent_key.tsx @@ -161,7 +161,7 @@ export function CreateAgentKeyFlyout({ onCancel, onSuccess, onError }: Props) { children: i18n.translate( 'xpack.apm.settings.agentKeys.createKeyFlyout.privilegesFieldset', { - defaultMessage: 'Assign privileges to the agent key', + defaultMessage: 'Assign privileges', } ), }} @@ -171,7 +171,7 @@ export function CreateAgentKeyFlyout({ onCancel, onSuccess, onError }: Props) { 'xpack.apm.settings.agentKeys.createKeyFlyout.agentConfigHelpText', { defaultMessage: - 'Required for agents to read Agent configuration remotely.', + 'Required for agents to read agent configuration remotely.', } )} > @@ -187,7 +187,7 @@ export function CreateAgentKeyFlyout({ onCancel, onSuccess, onError }: Props) { helpText={i18n.translate( 'xpack.apm.settings.agentKeys.createKeyFlyout.ingestAgentEvents', { - defaultMessage: 'Required for ingesting Agent events.', + defaultMessage: 'Required for ingesting events.', } )} > diff --git a/x-pack/plugins/apm/public/components/app/Settings/agent_keys/create_agent_key/agent_key_callout.tsx b/x-pack/plugins/apm/public/components/app/Settings/agent_keys/create_agent_key/agent_key_callout.tsx index a67b3821120fd..ace4ab02c38f5 100644 --- a/x-pack/plugins/apm/public/components/app/Settings/agent_keys/create_agent_key/agent_key_callout.tsx +++ b/x-pack/plugins/apm/public/components/app/Settings/agent_keys/create_agent_key/agent_key_callout.tsx @@ -27,7 +27,7 @@ export function AgentKeyCallOut({ name, token }: Props) { title={i18n.translate( 'xpack.apm.settings.agentKeys.copyAgentKeyField.title', { - defaultMessage: 'Created agent key "{name}"', + defaultMessage: 'Created "{name}" key', values: { name }, } )} diff --git a/x-pack/plugins/apm/public/components/app/Settings/agent_keys/index.tsx b/x-pack/plugins/apm/public/components/app/Settings/agent_keys/index.tsx index 3e2298fcffe6e..a63d2e0af9908 100644 --- a/x-pack/plugins/apm/public/components/app/Settings/agent_keys/index.tsx +++ b/x-pack/plugins/apm/public/components/app/Settings/agent_keys/index.tsx @@ -125,7 +125,7 @@ export function AgentKeys() { title={

{i18n.translate('xpack.apm.settings.agentKeys.emptyPromptTitle', { - defaultMessage: 'Create your first agent key', + defaultMessage: 'Create your first key', })}

} @@ -133,7 +133,7 @@ export function AgentKeys() {

{i18n.translate('xpack.apm.settings.agentKeys.emptyPromptBody', { defaultMessage: - 'Create agent keys to authorize requests to the APM Server.', + 'Create keys to authorize agent requests to the APM Server.', })}

} @@ -141,7 +141,7 @@ export function AgentKeys() { setIsFlyoutVisible(true)} fill={true} - iconType="plusInCircleFilled" + iconType="plusInCircle" > {i18n.translate( 'xpack.apm.settings.agentKeys.createAgentKeyButton', @@ -187,7 +187,7 @@ export function AgentKeys() { setIsFlyoutVisible(true)} fill={true} - iconType="plusInCircleFilled" + iconType="plusInCircle" > {i18n.translate( 'xpack.apm.settings.agentKeys.createAgentKeyButton',