From 8052d6781ba975140620cc7235d135faeace5823 Mon Sep 17 00:00:00 2001 From: Liza K Date: Tue, 3 Dec 2019 16:54:46 +0200 Subject: [PATCH] Don't export apply filters popup --- src/core/MIGRATION.md | 2 +- src/plugins/data/public/actions/apply_filter_action.ts | 2 +- src/plugins/data/public/ui/index.ts | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/core/MIGRATION.md b/src/core/MIGRATION.md index 84b99b034af99..2527ffba2cbbd 100644 --- a/src/core/MIGRATION.md +++ b/src/core/MIGRATION.md @@ -1193,7 +1193,7 @@ import { setup, start } from '../core_plugins/visualizations/public/legacy'; | Legacy Platform | New Platform | Notes | | ------------------------------------------------- | ------------------------------------------------------------ | ------------------------------------------------------------------------------------------------------------------------------------------------------------ | -| `import 'ui/apply_filters'` | `import { applyFiltersPopover } from '../data/public'` | Directive is deprecated. | +| `import 'ui/apply_filters'` | N/A. Replaced by triggering an APPLY_FILTER_TRIGGER trigger. | Directive is deprecated. | | `import 'ui/filter_bar'` | `import { FilterBar } from '../data/public'` | Directive is deprecated. | | `import 'ui/query_bar'` | `import { QueryStringInput } from '../data/public'` | Directives are deprecated. | | `import 'ui/search_bar'` | `import { SearchBar } from '../data/public'` | Directive is deprecated. | diff --git a/src/plugins/data/public/actions/apply_filter_action.ts b/src/plugins/data/public/actions/apply_filter_action.ts index afd986cf380c8..b006889637c50 100644 --- a/src/plugins/data/public/actions/apply_filter_action.ts +++ b/src/plugins/data/public/actions/apply_filter_action.ts @@ -21,11 +21,11 @@ import { i18n } from '@kbn/i18n'; import { toMountPoint } from '../../../kibana_react/public'; import { IAction, createAction, IncompatibleActionError } from '../../../ui_actions/public'; import { getOverlays, getIndexPatterns } from '../services'; +import { applyFiltersPopover } from '../ui/apply_filters'; import { esFilters, FilterManager, TimefilterContract, - applyFiltersPopover, changeTimeFilter, extractTimeFilter, } from '..'; diff --git a/src/plugins/data/public/ui/index.ts b/src/plugins/data/public/ui/index.ts index 9a4bccc21db3e..8bfccd49bdff3 100644 --- a/src/plugins/data/public/ui/index.ts +++ b/src/plugins/data/public/ui/index.ts @@ -20,7 +20,6 @@ export { SuggestionsComponent } from './typeahead/suggestions_component'; export { IndexPatternSelect } from './index_pattern_select'; export { FilterBar } from './filter_bar'; -export { applyFiltersPopover } from './apply_filters'; export { QueryStringInput } from './query_string_input/query_string_input'; // temp export - will be removed as final components are migrated to NP