From 7e03a259f58f9e7f3ab38342417ded934259f1d2 Mon Sep 17 00:00:00 2001
From: Brent Kimmel <bkimmel@endgame.com>
Date: Thu, 14 May 2020 14:45:28 -0400
Subject: [PATCH] R Austin / J Brown review: Add test coverage for selectors

---
 .../resolver/store/data/selectors.test.ts     | 52 +++++++++++++++++++
 .../resolver/view/process_event_dot.tsx       |  1 -
 2 files changed, 52 insertions(+), 1 deletion(-)
 create mode 100644 x-pack/plugins/endpoint/public/embeddables/resolver/store/data/selectors.test.ts

diff --git a/x-pack/plugins/endpoint/public/embeddables/resolver/store/data/selectors.test.ts b/x-pack/plugins/endpoint/public/embeddables/resolver/store/data/selectors.test.ts
new file mode 100644
index 0000000000000..368641c05c398
--- /dev/null
+++ b/x-pack/plugins/endpoint/public/embeddables/resolver/store/data/selectors.test.ts
@@ -0,0 +1,52 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import { Store, createStore } from 'redux';
+import { DataAction } from './action';
+import { dataReducer } from './reducer';
+import { DataState, RelatedEventDataEntry, RelatedEventDataEntryWithStats } from '../../types';
+import { ResolverEvent } from '../../../../../common/types';
+import { relatedEventStats, relatedEvents } from './selectors';
+
+describe('resolver data selectors', () => {
+  const store: Store<DataState, DataAction> = createStore(dataReducer, undefined);
+  describe('when related event data is reduced into state with no results', () => {
+    const relatedEventInfoBeforeAction = new Map(relatedEvents(store.getState()) || []);
+    beforeEach(() => {
+      const payload: Map<ResolverEvent, RelatedEventDataEntry> = new Map();
+      const action: DataAction = { type: 'serverReturnedRelatedEventData', payload };
+      store.dispatch(action);
+    });
+    it('should have the same related info as before the action', () => {
+      const relatedInfoAfterAction = relatedEvents(store.getState());
+      expect(relatedInfoAfterAction).toEqual(relatedEventInfoBeforeAction);
+    });
+  });
+  describe('when related event data is reduced into state with 2 dns results', () => {
+    const mockBaseEvent = {} as ResolverEvent;
+    beforeEach(() => {
+      function dnsRelatedEventEntry() {
+        const fakeEvent = {} as ResolverEvent;
+        return { relatedEvent: fakeEvent, relatedEventType: 'dns' };
+      }
+      const payload: Map<ResolverEvent, RelatedEventDataEntry> = new Map([
+        [
+          mockBaseEvent,
+          {
+            relatedEvents: [dnsRelatedEventEntry(), dnsRelatedEventEntry()],
+          },
+        ],
+      ]);
+      const action: DataAction = { type: 'serverReturnedRelatedEventData', payload };
+      store.dispatch(action);
+    });
+    it('should compile stats reflecting a count of 2 for dns', () => {
+      const actualStats = relatedEventStats(store.getState());
+      const statsForFakeEvent = actualStats.get(mockBaseEvent)! as RelatedEventDataEntryWithStats;
+      expect(statsForFakeEvent.stats).toEqual({ dns: 2 });
+    });
+  });
+});
diff --git a/x-pack/plugins/endpoint/public/embeddables/resolver/view/process_event_dot.tsx b/x-pack/plugins/endpoint/public/embeddables/resolver/view/process_event_dot.tsx
index f22f055a68654..0be0dd8e24faa 100644
--- a/x-pack/plugins/endpoint/public/embeddables/resolver/view/process_event_dot.tsx
+++ b/x-pack/plugins/endpoint/public/embeddables/resolver/view/process_event_dot.tsx
@@ -72,7 +72,6 @@ const nodeAssets = {
 const getDisplayName: (schemaName: string) => string = function nameInSchemaToDisplayName(
   schemaName: string
 ) {
-
   const displayNameRecord: Record<string, string> = {
     application: i18n.translate('xpack.endpoint.resolver.applicationEventTypeDisplayName', {
       defaultMessage: 'Application',