From 6ac90aafcdd56493f81e6bb970937289f8526e74 Mon Sep 17 00:00:00 2001 From: FrankHassanabad Date: Fri, 6 Nov 2020 11:34:16 -0700 Subject: [PATCH] Fix bugs found during PR review --- .../components/rules/step_define_rule/schema.tsx | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/x-pack/plugins/security_solution/public/detections/components/rules/step_define_rule/schema.tsx b/x-pack/plugins/security_solution/public/detections/components/rules/step_define_rule/schema.tsx index df701f4b196f2..e5574ea22eb1b 100644 --- a/x-pack/plugins/security_solution/public/detections/components/rules/step_define_rule/schema.tsx +++ b/x-pack/plugins/security_solution/public/detections/components/rules/step_define_rule/schema.tsx @@ -77,12 +77,11 @@ export const schema: FormSchema = { ...args: Parameters ): ReturnType> | undefined => { const [{ value, path, formData }] = args; - const { query, filters, edited } = value as DefineStepRule['queryBar']; + const { query, filters } = value as DefineStepRule['queryBar']; const needsValidation = !isMlRule(formData.ruleType); - if (!needsValidation || edited === false) { + if (!needsValidation) { return; } - return isEmpty(query.query as string) && isEmpty(filters) ? { code: 'ERR_FIELD_MISSING', @@ -97,9 +96,9 @@ export const schema: FormSchema = { ...args: Parameters ): ReturnType> | undefined => { const [{ value, path, formData }] = args; - const { query, edited } = value as DefineStepRule['queryBar']; + const { query } = value as DefineStepRule['queryBar']; const needsValidation = !isMlRule(formData.ruleType); - if (!needsValidation || edited === false) { + if (!needsValidation) { return; }