From 6367b17d20b85b583033a0e8ff4e2d368cc83712 Mon Sep 17 00:00:00 2001
From: Joe Reuter <johannes.reuter@elastic.co>
Date: Sat, 27 Nov 2021 12:25:11 +0100
Subject: [PATCH] hide fit from suggestions (#119568)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
---
 src/plugins/vis_types/timelion/common/types.ts                  | 1 +
 .../public/components/timelion_expression_input_helpers.ts      | 2 +-
 src/plugins/vis_types/timelion/server/lib/classes/datasource.js | 1 +
 .../vis_types/timelion/server/series_functions/es/index.js      | 1 +
 4 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/plugins/vis_types/timelion/common/types.ts b/src/plugins/vis_types/timelion/common/types.ts
index 8ce4bd8b45f0..323539f69488 100644
--- a/src/plugins/vis_types/timelion/common/types.ts
+++ b/src/plugins/vis_types/timelion/common/types.ts
@@ -20,6 +20,7 @@ export interface TimelionFunctionArgs {
   multi?: boolean;
   types: TimelionFunctionArgsTypes[];
   suggestions?: TimelionFunctionArgsSuggestion[];
+  hidden?: boolean;
 }
 
 export interface ITimelionFunction {
diff --git a/src/plugins/vis_types/timelion/public/components/timelion_expression_input_helpers.ts b/src/plugins/vis_types/timelion/public/components/timelion_expression_input_helpers.ts
index 6c3cd8058627..676b5d91a803 100644
--- a/src/plugins/vis_types/timelion/public/components/timelion_expression_input_helpers.ts
+++ b/src/plugins/vis_types/timelion/public/components/timelion_expression_input_helpers.ts
@@ -42,7 +42,7 @@ function getArgumentsHelp(
 
   // ignore arguments that are already provided in function declaration
   const functionArgNames = functionArgs.map((arg) => arg.name);
-  return argsHelp.filter((arg) => !functionArgNames.includes(arg.name));
+  return argsHelp.filter((arg) => !arg.hidden && !functionArgNames.includes(arg.name));
 }
 
 async function extractSuggestionsFromParsedResult(
diff --git a/src/plugins/vis_types/timelion/server/lib/classes/datasource.js b/src/plugins/vis_types/timelion/server/lib/classes/datasource.js
index f0af22793c98..50129494bf84 100644
--- a/src/plugins/vis_types/timelion/server/lib/classes/datasource.js
+++ b/src/plugins/vis_types/timelion/server/lib/classes/datasource.js
@@ -47,6 +47,7 @@ export default class Datasource extends TimelionFunction {
           fitFunctions: _.keys(fitFunctions).join(', '),
         },
       }),
+      hidden: Boolean(config.hideFitArg),
     });
 
     // Wrap the original function so we can modify inputs/outputs with offset & fit
diff --git a/src/plugins/vis_types/timelion/server/series_functions/es/index.js b/src/plugins/vis_types/timelion/server/series_functions/es/index.js
index 663d7714774c..d613818d7c3e 100644
--- a/src/plugins/vis_types/timelion/server/series_functions/es/index.js
+++ b/src/plugins/vis_types/timelion/server/series_functions/es/index.js
@@ -13,6 +13,7 @@ import buildRequest from './lib/build_request';
 import toSeriesList from './lib/agg_response_to_series_list';
 
 export default new Datasource('es', {
+  hideFitArg: true,
   args: [
     {
       name: 'q',