From 62dc71569b1a06e9bbf6de74ac5681dfb36045b8 Mon Sep 17 00:00:00 2001
From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Date: Mon, 1 Aug 2022 12:00:19 -0400
Subject: [PATCH] [ML] Explain log rates spikes: Fix API messages translations.
 (#137589) (#137720)

Adds translations to API status messages to fix singular/plural issues with dynamic messages.

(cherry picked from commit ee6d46972fb48079a881fd54fbdeda3c2da9b0a6)

Co-authored-by: Walter Rafelsberger <walter@elastic.co>
---
 .../server/routes/explain_log_rate_spikes.ts  | 60 ++++++++++++++-----
 .../apis/aiops/explain_log_rate_spikes.ts     |  4 +-
 2 files changed, 48 insertions(+), 16 deletions(-)

diff --git a/x-pack/plugins/aiops/server/routes/explain_log_rate_spikes.ts b/x-pack/plugins/aiops/server/routes/explain_log_rate_spikes.ts
index 65ed2065d7ade..cb0911e1c53be 100644
--- a/x-pack/plugins/aiops/server/routes/explain_log_rate_spikes.ts
+++ b/x-pack/plugins/aiops/server/routes/explain_log_rate_spikes.ts
@@ -7,6 +7,7 @@
 
 import { chunk } from 'lodash';
 
+import { i18n } from '@kbn/i18n';
 import { asyncForEach } from '@kbn/std';
 import type { IRouter } from '@kbn/core/server';
 import { KBN_FIELD_TYPES } from '@kbn/field-types';
@@ -81,7 +82,12 @@ export const defineExplainLogRateSpikesRoute = (
           updateLoadingStateAction({
             ccsWarning: false,
             loaded,
-            loadingState: 'Loading field candidates.',
+            loadingState: i18n.translate(
+              'xpack.aiops.explainLogRateSpikes.loadingState.loadingFieldCandidates',
+              {
+                defaultMessage: 'Loading field candidates.',
+              }
+            ),
           })
         );
 
@@ -104,7 +110,16 @@ export const defineExplainLogRateSpikesRoute = (
           updateLoadingStateAction({
             ccsWarning: false,
             loaded,
-            loadingState: `Identified ${fieldCandidates.length} field candidates.`,
+            loadingState: i18n.translate(
+              'xpack.aiops.explainLogRateSpikes.loadingState.identifiedFieldCandidates',
+              {
+                defaultMessage:
+                  'Identified {fieldCandidatesCount, plural, one {# field candidate} other {# field candidates}}.',
+                values: {
+                  fieldCandidatesCount: fieldCandidates.length,
+                },
+              }
+            ),
           })
         );
 
@@ -144,9 +159,16 @@ export const defineExplainLogRateSpikesRoute = (
             updateLoadingStateAction({
               ccsWarning: false,
               loaded,
-              loadingState: `Identified ${
-                changePoints?.length ?? 0
-              } significant field/value pairs.`,
+              loadingState: i18n.translate(
+                'xpack.aiops.explainLogRateSpikes.loadingState.identifiedFieldValuePairs',
+                {
+                  defaultMessage:
+                    'Identified {fieldValuePairsCount, plural, one {# significant field/value pair} other {# significant field/value pairs}}.',
+                  values: {
+                    fieldValuePairsCount: changePoints?.length ?? 0,
+                  },
+                }
+              ),
             })
           );
 
@@ -157,14 +179,6 @@ export const defineExplainLogRateSpikesRoute = (
         }
 
         if (changePoints?.length === 0) {
-          push(
-            updateLoadingStateAction({
-              ccsWarning: false,
-              loaded: 1,
-              loadingState: `Done.`,
-            })
-          );
-
           end();
           return;
         }
@@ -239,7 +253,12 @@ export const defineExplainLogRateSpikesRoute = (
                 updateLoadingStateAction({
                   ccsWarning: false,
                   loaded,
-                  loadingState: `Loading histogram data.`,
+                  loadingState: i18n.translate(
+                    'xpack.aiops.explainLogRateSpikes.loadingState.loadingHistogramData',
+                    {
+                      defaultMessage: 'Loading histogram data.',
+                    }
+                  ),
                 })
               );
               push(
@@ -255,6 +274,19 @@ export const defineExplainLogRateSpikesRoute = (
           });
         }
 
+        push(
+          updateLoadingStateAction({
+            ccsWarning: false,
+            loaded: 1,
+            loadingState: i18n.translate(
+              'xpack.aiops.explainLogRateSpikes.loadingState.doneMessage',
+              {
+                defaultMessage: 'Done.',
+              }
+            ),
+          })
+        );
+
         end();
       })();
 
diff --git a/x-pack/test/api_integration/apis/aiops/explain_log_rate_spikes.ts b/x-pack/test/api_integration/apis/aiops/explain_log_rate_spikes.ts
index f2b606ff183cd..5bf3ae04a2743 100644
--- a/x-pack/test/api_integration/apis/aiops/explain_log_rate_spikes.ts
+++ b/x-pack/test/api_integration/apis/aiops/explain_log_rate_spikes.ts
@@ -34,8 +34,8 @@ export default ({ getService }: FtrProviderContext) => {
   };
 
   const expected = {
-    chunksLength: 12,
-    actionsLength: 11,
+    chunksLength: 13,
+    actionsLength: 12,
     noIndexChunksLength: 4,
     noIndexActionsLength: 3,
     changePointFilter: 'add_change_points',