From 5bb93ee85db05223aab2c319797ffb52f12ce688 Mon Sep 17 00:00:00 2001 From: James Gowdy Date: Wed, 4 Jul 2018 10:38:38 +0100 Subject: [PATCH] changes based on review --- .../jobs_list_new/components/job_filter_bar/job_filter_bar.js | 4 ++-- .../plugins/ml/public/jobs/jobs_list_new/components/utils.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/x-pack/plugins/ml/public/jobs/jobs_list_new/components/job_filter_bar/job_filter_bar.js b/x-pack/plugins/ml/public/jobs/jobs_list_new/components/job_filter_bar/job_filter_bar.js index 3a96ff5a2f0f9..297a27c869384 100644 --- a/x-pack/plugins/ml/public/jobs/jobs_list_new/components/job_filter_bar/job_filter_bar.js +++ b/x-pack/plugins/ml/public/jobs/jobs_list_new/components/job_filter_bar/job_filter_bar.js @@ -19,7 +19,7 @@ import { EuiSearchBar, } from '@elastic/eui'; -const loadGroups = () => { +function loadGroups() { return ml.jobs.groups() .then((groups) => { return groups.map(g => ({ @@ -35,7 +35,7 @@ const loadGroups = () => { console.log(error); return []; }); -}; +} export class JobFilterBar extends Component { constructor(props) { diff --git a/x-pack/plugins/ml/public/jobs/jobs_list_new/components/utils.js b/x-pack/plugins/ml/public/jobs/jobs_list_new/components/utils.js index 294b5b7c861a2..3b825d9ef670b 100644 --- a/x-pack/plugins/ml/public/jobs/jobs_list_new/components/utils.js +++ b/x-pack/plugins/ml/public/jobs/jobs_list_new/components/utils.js @@ -144,7 +144,7 @@ export function filterJobs(jobs, clauses) { } // keep count of the number of matches we make as we're looping over the clauses - // we only want to return jobs with match all clauses, i.e. each search term is ANDed + // we only want to return jobs which match all clauses, i.e. each search term is ANDed const matches = jobs.reduce((p, c) => { p[c.id] = { job: c,