From 561f8b602de5b68448f80109611bd5ed4bec8771 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20Fern=C3=A1ndez=20Haro?= Date: Wed, 18 Dec 2024 00:58:45 +0100 Subject: [PATCH] Improve skip decision logic --- x-pack/test/api_integration/apis/upgrade_assistant/index.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/x-pack/test/api_integration/apis/upgrade_assistant/index.ts b/x-pack/test/api_integration/apis/upgrade_assistant/index.ts index 61e2dbce21fee..1f56a4a9563ed 100644 --- a/x-pack/test/api_integration/apis/upgrade_assistant/index.ts +++ b/x-pack/test/api_integration/apis/upgrade_assistant/index.ts @@ -14,12 +14,11 @@ export default function ({ loadTestFile, getService }: FtrProviderContext) { before( "Check version to avoid failures during forward-compatibility tests where these don't make sense", - async () => { + async function () { const { version: { number: esVersion }, } = await es.info(); - if (esVersion !== kibanaVersion) { - // @ts-expect-error for some reason TS thinks it's jest and not mocha: https://mochajs.org/#inclusive-tests + if (esVersion.replace('-SNAPSHOT', '') !== kibanaVersion.replace('-SNAPSHOT', '')) { this.skip(); } }