From 51f6fdfa73d77a22af9b2c4b80666478ef69009c Mon Sep 17 00:00:00 2001
From: Robert Oskamp <robert.oskamp@elastic.co>
Date: Thu, 30 Jul 2020 07:32:36 +0200
Subject: [PATCH] [ML] Functional tests - stabilize DFA navigation and index
 pattern handling (#73660) (#73679)

This PR adds a few stability fixes around DFA creation and cloning.
---
 .../apps/ml/data_frame_analytics/cloning.ts    |  1 +
 .../ml/data_frame_analytics_creation.ts        | 18 ++++++++++++------
 .../functional/services/ml/test_resources.ts   |  2 +-
 3 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/x-pack/test/functional/apps/ml/data_frame_analytics/cloning.ts b/x-pack/test/functional/apps/ml/data_frame_analytics/cloning.ts
index e2f7960f9d856..00be1b8e12b49 100644
--- a/x-pack/test/functional/apps/ml/data_frame_analytics/cloning.ts
+++ b/x-pack/test/functional/apps/ml/data_frame_analytics/cloning.ts
@@ -157,6 +157,7 @@ export default function ({ getService }: FtrProviderContext) {
           await ml.api.deleteIndices(cloneDestIndex);
           await ml.api.deleteIndices(testData.job.dest!.index as string);
           await ml.testResources.deleteIndexPatternByTitle(testData.job.dest!.index as string);
+          await ml.testResources.deleteIndexPatternByTitle(cloneDestIndex);
         });
 
         it('should open the wizard with a proper header', async () => {
diff --git a/x-pack/test/functional/services/ml/data_frame_analytics_creation.ts b/x-pack/test/functional/services/ml/data_frame_analytics_creation.ts
index e36855a4e769e..9cb53867d6a12 100644
--- a/x-pack/test/functional/services/ml/data_frame_analytics_creation.ts
+++ b/x-pack/test/functional/services/ml/data_frame_analytics_creation.ts
@@ -333,18 +333,24 @@ export function MachineLearningDataFrameAnalyticsCreationProvider(
     },
 
     async continueToAdditionalOptionsStep() {
-      await testSubjects.clickWhenNotDisabled('mlAnalyticsCreateJobWizardContinueButton');
-      await this.assertAdditionalOptionsStepActive();
+      await retry.tryForTime(5000, async () => {
+        await testSubjects.clickWhenNotDisabled('mlAnalyticsCreateJobWizardContinueButton');
+        await this.assertAdditionalOptionsStepActive();
+      });
     },
 
     async continueToDetailsStep() {
-      await testSubjects.clickWhenNotDisabled('mlAnalyticsCreateJobWizardContinueButton');
-      await this.assertDetailsStepActive();
+      await retry.tryForTime(5000, async () => {
+        await testSubjects.clickWhenNotDisabled('mlAnalyticsCreateJobWizardContinueButton');
+        await this.assertDetailsStepActive();
+      });
     },
 
     async continueToCreateStep() {
-      await testSubjects.clickWhenNotDisabled('mlAnalyticsCreateJobWizardContinueButton');
-      await this.assertCreateStepActive();
+      await retry.tryForTime(5000, async () => {
+        await testSubjects.clickWhenNotDisabled('mlAnalyticsCreateJobWizardContinueButton');
+        await this.assertCreateStepActive();
+      });
     },
 
     async assertModelMemoryInputExists() {
diff --git a/x-pack/test/functional/services/ml/test_resources.ts b/x-pack/test/functional/services/ml/test_resources.ts
index 9927c987bbea5..942dc4a80d4ac 100644
--- a/x-pack/test/functional/services/ml/test_resources.ts
+++ b/x-pack/test/functional/services/ml/test_resources.ts
@@ -56,7 +56,7 @@ export function MachineLearningTestResourcesProvider({ getService }: FtrProvider
     ): Promise<string | undefined> {
       log.debug(`Searching for '${objectType}' with title '${title}'...`);
       const findResponse = await supertest
-        .get(`/api/saved_objects/_find?type=${objectType}`)
+        .get(`/api/saved_objects/_find?type=${objectType}&per_page=10000`)
         .set(COMMON_REQUEST_HEADERS)
         .expect(200)
         .then((res: any) => res.body);