From 51df1e58a38892e4db648678899c185a9f44e596 Mon Sep 17 00:00:00 2001
From: Diana Derevyankina
 <54894989+DziyanaDzeraviankina@users.noreply.github.com>
Date: Mon, 4 Oct 2021 20:15:57 +0300
Subject: [PATCH] [TSVB] Rename Index pattern to Data view (#110253)

* [TSVB] Rename Index pattern to Data view

* Update some labels

* Make asterisk bold to indicate it's text input

* Remove redundant translation

* Remove "now" from TSVB callout notification title

* Update variable name to match the text

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
---
 .../index_pattern_select.tsx                  | 37 ++++++++++---------
 .../switch_mode_popover.tsx                   |  9 ++---
 .../application/components/series_config.js   |  4 +-
 .../use_index_patter_mode_callout.tsx         | 12 +++---
 .../components/vis_types/timeseries/config.js |  4 +-
 .../translations/translations/ja-JP.json      | 13 +------
 .../translations/translations/zh-CN.json      | 13 +------
 7 files changed, 38 insertions(+), 54 deletions(-)

diff --git a/src/plugins/vis_types/timeseries/public/application/components/lib/index_pattern_select/index_pattern_select.tsx b/src/plugins/vis_types/timeseries/public/application/components/lib/index_pattern_select/index_pattern_select.tsx
index 1029ac67cc43c..d28e2c5e0fb9a 100644
--- a/src/plugins/vis_types/timeseries/public/application/components/lib/index_pattern_select/index_pattern_select.tsx
+++ b/src/plugins/vis_types/timeseries/public/application/components/lib/index_pattern_select/index_pattern_select.tsx
@@ -33,22 +33,28 @@ export interface IndexPatternSelectProps {
     | null;
 }
 
-const defaultIndexPatternHelpText = i18n.translate(
-  'visTypeTimeseries.indexPatternSelect.defaultIndexPatternText',
-  {
-    defaultMessage: 'Default index pattern is used.',
-  }
+const queryAllIndicesHelpText = (
+  <FormattedMessage
+    id="visTypeTimeseries.indexPatternSelect.queryAllIndicesText"
+    defaultMessage="To query all indices, use {asterisk}."
+    values={{
+      asterisk: <strong>*</strong>,
+    }}
+  />
 );
 
-const queryAllIndexesHelpText = i18n.translate(
-  'visTypeTimeseries.indexPatternSelect.queryAllIndexesText',
-  {
-    defaultMessage: 'To query all indexes use *',
-  }
+const getIndexPatternHelpText = (useKibanaIndices: boolean) => (
+  <FormattedMessage
+    id="visTypeTimeseries.indexPatternSelect.defaultDataViewText"
+    defaultMessage="Using the default data view. {queryAllIndicesHelpText}"
+    values={{
+      queryAllIndicesHelpText: useKibanaIndices ? '' : queryAllIndicesHelpText,
+    }}
+  />
 );
 
 const indexPatternLabel = i18n.translate('visTypeTimeseries.indexPatternSelect.label', {
-  defaultMessage: 'Index pattern',
+  defaultMessage: 'Data view',
 });
 
 export const IndexPatternSelect = ({
@@ -103,17 +109,14 @@ export const IndexPatternSelect = ({
     <EuiFormRow
       id={htmlId('indexPattern')}
       label={indexPatternLabel}
-      helpText={
-        fetchedIndex.defaultIndex &&
-        defaultIndexPatternHelpText + (!useKibanaIndices ? queryAllIndexesHelpText : '')
-      }
+      helpText={fetchedIndex.defaultIndex && getIndexPatternHelpText(useKibanaIndices)}
       labelAppend={
         fetchedIndex.indexPatternString && !fetchedIndex.indexPattern ? (
           <EuiLink onClick={navigateToCreateIndexPatternPage}>
             <EuiText size="xs">
               <FormattedMessage
-                id="visTypeTimeseries.indexPatternSelect.createIndexPatternText"
-                defaultMessage="Create index pattern"
+                id="visTypeTimeseries.indexPatternSelect.createDataViewText"
+                defaultMessage="Create data view"
               />
             </EuiText>
           </EuiLink>
diff --git a/src/plugins/vis_types/timeseries/public/application/components/lib/index_pattern_select/switch_mode_popover.tsx b/src/plugins/vis_types/timeseries/public/application/components/lib/index_pattern_select/switch_mode_popover.tsx
index 43ef091da251d..5e66b50eac467 100644
--- a/src/plugins/vis_types/timeseries/public/application/components/lib/index_pattern_select/switch_mode_popover.tsx
+++ b/src/plugins/vis_types/timeseries/public/application/components/lib/index_pattern_select/switch_mode_popover.tsx
@@ -79,7 +79,7 @@ export const SwitchModePopover = ({ onModeChange, useKibanaIndices }: PopoverPro
           aria-label={i18n.translate(
             'visTypeTimeseries.indexPatternSelect.switchModePopover.areaLabel',
             {
-              defaultMessage: 'Configure index pattern selection mode',
+              defaultMessage: 'Configure data view selection mode',
             }
           )}
           onClick={onButtonClick}
@@ -97,14 +97,13 @@ export const SwitchModePopover = ({ onModeChange, useKibanaIndices }: PopoverPro
       >
         <EuiPopoverTitle>
           {i18n.translate('visTypeTimeseries.indexPatternSelect.switchModePopover.title', {
-            defaultMessage: 'Index pattern selection mode',
+            defaultMessage: 'Data view mode',
           })}
         </EuiPopoverTitle>
         <EuiText>
           <FormattedMessage
             id="visTypeTimeseries.indexPatternSelect.switchModePopover.text"
-            defaultMessage="An index pattern identifies one or more Elasticsearch indices that you want to explore.
-            Kibana index patterns are used by default. {allowStringIndicesLabel}"
+            defaultMessage="A data view groups and retrieves data from Elasticsearch. Disable this mode to directly query Elasticsearch indices instead. {allowStringIndicesLabel}"
             values={{
               allowStringIndicesLabel,
             }}
@@ -116,7 +115,7 @@ export const SwitchModePopover = ({ onModeChange, useKibanaIndices }: PopoverPro
           label={i18n.translate(
             'visTypeTimeseries.indexPatternSelect.switchModePopover.useKibanaIndices',
             {
-              defaultMessage: 'Use only index patterns',
+              defaultMessage: 'Use Kibana data views',
             }
           )}
           onChange={switchMode}
diff --git a/src/plugins/vis_types/timeseries/public/application/components/series_config.js b/src/plugins/vis_types/timeseries/public/application/components/series_config.js
index b4907d4eaa5c2..8189925b2f838 100644
--- a/src/plugins/vis_types/timeseries/public/application/components/series_config.js
+++ b/src/plugins/vis_types/timeseries/public/application/components/series_config.js
@@ -119,8 +119,8 @@ export const SeriesConfig = (props) => {
       <EuiFlexGroup gutterSize="s" responsive={false} wrap={true}>
         <EuiFlexItem grow={false}>
           <EuiFormRow
-            label={i18n.translate('visTypeTimeseries.seriesConfig.overrideIndexPatternLabel', {
-              defaultMessage: 'Override Index Pattern?',
+            label={i18n.translate('visTypeTimeseries.seriesConfig.overrideDataViewLabel', {
+              defaultMessage: 'Override data view?',
             })}
           >
             <YesNo
diff --git a/src/plugins/vis_types/timeseries/public/application/components/use_index_patter_mode_callout.tsx b/src/plugins/vis_types/timeseries/public/application/components/use_index_patter_mode_callout.tsx
index 9684b7b7ff356..b448bd80c0270 100644
--- a/src/plugins/vis_types/timeseries/public/application/components/use_index_patter_mode_callout.tsx
+++ b/src/plugins/vis_types/timeseries/public/application/components/use_index_patter_mode_callout.tsx
@@ -33,8 +33,8 @@ export const UseIndexPatternModeCallout = () => {
     <EuiCallOut
       title={
         <FormattedMessage
-          id="visTypeTimeseries.visEditorVisualization.indexPatternMode.notificationTitle"
-          defaultMessage="TSVB now supports index patterns"
+          id="visTypeTimeseries.visEditorVisualization.dataViewMode.notificationTitle"
+          defaultMessage="TSVB supports data views"
         />
       }
       iconType="cheer"
@@ -42,13 +42,13 @@ export const UseIndexPatternModeCallout = () => {
     >
       <p>
         <FormattedMessage
-          id="visTypeTimeseries.visEditorVisualization.indexPatternMode.notificationMessage"
-          defaultMessage="Great news! You can now visualize the data from Kibana index patterns (recommended) or Elasticsearch indices. {indexPatternModeLink}."
+          id="visTypeTimeseries.visEditorVisualization.dataViewMode.notificationMessage"
+          defaultMessage="Great news! You can visualize the data from Kibana data views (recommended) or Elasticsearch indices. {indexPatternModeLink}."
           values={{
             indexPatternModeLink: (
               <EuiLink href={indexPatternModeLink} target="_blank" external>
                 <FormattedMessage
-                  id="visTypeTimeseries.visEditorVisualization.indexPatternMode.link"
+                  id="visTypeTimeseries.visEditorVisualization.dataViewMode.link"
                   defaultMessage="Check it out."
                 />
               </EuiLink>
@@ -59,7 +59,7 @@ export const UseIndexPatternModeCallout = () => {
       <EuiFlexGroup gutterSize="none">
         <EuiButton size="s" onClick={dismissNotice}>
           <FormattedMessage
-            id="visTypeTimeseries.visEditorVisualization.indexPatternMode.dismissNoticeButtonText"
+            id="visTypeTimeseries.visEditorVisualization.dataViewMode.dismissNoticeButtonText"
             defaultMessage="Dismiss"
           />
         </EuiButton>
diff --git a/src/plugins/vis_types/timeseries/public/application/components/vis_types/timeseries/config.js b/src/plugins/vis_types/timeseries/public/application/components/vis_types/timeseries/config.js
index 4257c35a6d4c2..208f9af9bb250 100644
--- a/src/plugins/vis_types/timeseries/public/application/components/vis_types/timeseries/config.js
+++ b/src/plugins/vis_types/timeseries/public/application/components/vis_types/timeseries/config.js
@@ -538,8 +538,8 @@ export const TimeseriesConfig = injectI18n(function (props) {
       <EuiFlexGroup gutterSize="s" responsive={false} wrap={true}>
         <EuiFlexItem grow={false}>
           <EuiFormRow
-            label={i18n.translate('visTypeTimeseries.timeSeries.overrideIndexPatternLabel', {
-              defaultMessage: 'Override Index Pattern?',
+            label={i18n.translate('visTypeTimeseries.timeSeries.overrideDataViewLabel', {
+              defaultMessage: 'Override data view?',
             })}
           >
             <YesNo
diff --git a/x-pack/plugins/translations/translations/ja-JP.json b/x-pack/plugins/translations/translations/ja-JP.json
index 53932d381dfdd..b1bcc0b67eecb 100644
--- a/x-pack/plugins/translations/translations/ja-JP.json
+++ b/x-pack/plugins/translations/translations/ja-JP.json
@@ -5198,12 +5198,6 @@
     "visTypeTimeseries.indexPattern.timeRange.lastValue": "最終値",
     "visTypeTimeseries.indexPattern.timeRange.selectTimeRange": "選択してください",
     "visTypeTimeseries.indexPattern.сoarse": "粗い",
-    "visTypeTimeseries.indexPatternSelect.createIndexPatternText": "インデックスパターンを作成",
-    "visTypeTimeseries.indexPatternSelect.defaultIndexPatternText": "デフォルトのインデックスパターンが使用されています。",
-    "visTypeTimeseries.indexPatternSelect.label": "インデックスパターン",
-    "visTypeTimeseries.indexPatternSelect.queryAllIndexesText": "すべてのインデックスにクエリを実行するには * を使用します",
-    "visTypeTimeseries.indexPatternSelect.switchModePopover.areaLabel": "インデックスパターン選択モードを構成",
-    "visTypeTimeseries.indexPatternSelect.switchModePopover.title": "インデックスパターン選択モード",
     "visTypeTimeseries.kbnVisTypes.metricsDescription": "時系列データの高度な分析を実行します。",
     "visTypeTimeseries.kbnVisTypes.metricsTitle": "TSVB",
     "visTypeTimeseries.lastValueModeIndicator.lastBucketDate": "バケット：{lastBucketDate}",
@@ -5332,7 +5326,6 @@
     "visTypeTimeseries.seriesConfig.ignoreGlobalFilterLabel": "グローバルフィルターを無視しますか？",
     "visTypeTimeseries.seriesConfig.missingSeriesComponentDescription": "パネルタイプ {panelType} の数列コンポーネントが欠けています",
     "visTypeTimeseries.seriesConfig.offsetSeriesTimeLabel": "数列の時間を（1m, 1h, 1w, 1d）でオフセット",
-    "visTypeTimeseries.seriesConfig.overrideIndexPatternLabel": "インデックスパターンを上書きしますか？",
     "visTypeTimeseries.seriesConfig.templateHelpText": "eg. {templateExample}",
     "visTypeTimeseries.seriesConfig.templateLabel": "テンプレート",
     "visTypeTimeseries.sort.dragToSortAriaLabel": "ドラッグして並べ替えます",
@@ -5463,7 +5456,6 @@
     "visTypeTimeseries.timeseries.optionsTab.styleLabel": "スタイル",
     "visTypeTimeseries.timeseries.optionsTab.tooltipMode": "ツールチップ",
     "visTypeTimeseries.timeseries.optionsTab.truncateLegendLabel": "凡例を切り捨てますか？",
-    "visTypeTimeseries.timeSeries.overrideIndexPatternLabel": "インデックスパターンを上書きしますか？",
     "visTypeTimeseries.timeSeries.percentLabel": "パーセント",
     "visTypeTimeseries.timeseries.positionOptions.leftLabel": "左",
     "visTypeTimeseries.timeseries.positionOptions.rightLabel": "右",
@@ -5528,9 +5520,8 @@
     "visTypeTimeseries.visEditorVisualization.changesHaveNotBeenAppliedMessage": "ビジュアライゼーションへの変更が適用されました。",
     "visTypeTimeseries.visEditorVisualization.changesSuccessfullyAppliedMessage": "最新の変更が適用されました。",
     "visTypeTimeseries.visEditorVisualization.changesWillBeAutomaticallyAppliedMessage": "変更が自動的に適用されます。",
-    "visTypeTimeseries.visEditorVisualization.indexPatternMode.dismissNoticeButtonText": "閉じる",
-    "visTypeTimeseries.visEditorVisualization.indexPatternMode.link": "確認してください。",
-    "visTypeTimeseries.visEditorVisualization.indexPatternMode.notificationTitle": "TSVBはインデックスパターンをサポートします",
+    "visTypeTimeseries.visEditorVisualization.dataViewMode.dismissNoticeButtonText": "閉じる",
+    "visTypeTimeseries.visEditorVisualization.dataViewMode.link": "確認してください。",
     "visTypeTimeseries.visPicker.gaugeLabel": "ゲージ",
     "visTypeTimeseries.visPicker.metricLabel": "メトリック",
     "visTypeTimeseries.visPicker.tableLabel": "表",
diff --git a/x-pack/plugins/translations/translations/zh-CN.json b/x-pack/plugins/translations/translations/zh-CN.json
index 1f00b1c910190..d8bd9774551d8 100644
--- a/x-pack/plugins/translations/translations/zh-CN.json
+++ b/x-pack/plugins/translations/translations/zh-CN.json
@@ -5241,12 +5241,6 @@
     "visTypeTimeseries.indexPattern.timeRange.lastValue": "最后值",
     "visTypeTimeseries.indexPattern.timeRange.selectTimeRange": "选择",
     "visTypeTimeseries.indexPattern.сoarse": "粗糙",
-    "visTypeTimeseries.indexPatternSelect.createIndexPatternText": "创建索引模式",
-    "visTypeTimeseries.indexPatternSelect.defaultIndexPatternText": "将使用默认索引模式。",
-    "visTypeTimeseries.indexPatternSelect.label": "索引模式",
-    "visTypeTimeseries.indexPatternSelect.queryAllIndexesText": "要查询所有索引，请使用 *",
-    "visTypeTimeseries.indexPatternSelect.switchModePopover.areaLabel": "配置索引模式选择模式",
-    "visTypeTimeseries.indexPatternSelect.switchModePopover.title": "索引模式选择模式",
     "visTypeTimeseries.kbnVisTypes.metricsDescription": "对时间序列数据执行高级分析。",
     "visTypeTimeseries.kbnVisTypes.metricsTitle": "TSVB",
     "visTypeTimeseries.lastValueModeIndicator.lastBucketDate": "存储桶：{lastBucketDate}",
@@ -5376,7 +5370,6 @@
     "visTypeTimeseries.seriesConfig.ignoreGlobalFilterLabel": "忽略全局筛选？",
     "visTypeTimeseries.seriesConfig.missingSeriesComponentDescription": "以下面板类型缺失序列组件：{panelType}",
     "visTypeTimeseries.seriesConfig.offsetSeriesTimeLabel": "将序列时间偏移（1m、1h、1w、1d）",
-    "visTypeTimeseries.seriesConfig.overrideIndexPatternLabel": "覆盖索引模式？",
     "visTypeTimeseries.seriesConfig.templateHelpText": "例如 {templateExample}",
     "visTypeTimeseries.seriesConfig.templateLabel": "模板",
     "visTypeTimeseries.sort.dragToSortAriaLabel": "拖动以排序",
@@ -5507,7 +5500,6 @@
     "visTypeTimeseries.timeseries.optionsTab.styleLabel": "样式",
     "visTypeTimeseries.timeseries.optionsTab.tooltipMode": "工具提示",
     "visTypeTimeseries.timeseries.optionsTab.truncateLegendLabel": "截断图例？",
-    "visTypeTimeseries.timeSeries.overrideIndexPatternLabel": "覆盖索引模式？",
     "visTypeTimeseries.timeSeries.percentLabel": "百分比",
     "visTypeTimeseries.timeseries.positionOptions.leftLabel": "左",
     "visTypeTimeseries.timeseries.positionOptions.rightLabel": "右",
@@ -5572,9 +5564,8 @@
     "visTypeTimeseries.visEditorVisualization.changesHaveNotBeenAppliedMessage": "尚未应用对此可视化的更改。",
     "visTypeTimeseries.visEditorVisualization.changesSuccessfullyAppliedMessage": "已应用最新更改。",
     "visTypeTimeseries.visEditorVisualization.changesWillBeAutomaticallyAppliedMessage": "将自动应用更改。",
-    "visTypeTimeseries.visEditorVisualization.indexPatternMode.dismissNoticeButtonText": "关闭",
-    "visTypeTimeseries.visEditorVisualization.indexPatternMode.link": "请查看。",
-    "visTypeTimeseries.visEditorVisualization.indexPatternMode.notificationTitle": "TSVB 现在支持索引模式",
+    "visTypeTimeseries.visEditorVisualization.dataViewMode.dismissNoticeButtonText": "关闭",
+    "visTypeTimeseries.visEditorVisualization.dataViewMode.link": "请查看。",
     "visTypeTimeseries.visPicker.gaugeLabel": "仪表盘",
     "visTypeTimeseries.visPicker.metricLabel": "指标",
     "visTypeTimeseries.visPicker.tableLabel": "表",