From 41bb84d7a04918f15512b3de73ab16e325809dac Mon Sep 17 00:00:00 2001
From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Date: Wed, 25 Sep 2024 19:01:15 +1000
Subject: [PATCH] [8.x] [HTTP] Set explicit access for &#x60;public&#x60; HTTP
 APIs 2 (#192579) (#193938)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[HTTP] Set explicit access for &#x60;public&#x60; HTTP APIs 2
(#192579)](https://github.com/elastic/kibana/pull/192579)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jean-Louis
Leysens","email":"jeanlouis.leysens@elastic.co"},"sourceCommit":{"committedDate":"2024-09-25T07:25:12Z","message":"[HTTP]
Set explicit access for `public` HTTP APIs 2 (#192579)\n\n##
Summary\r\n\r\nPart 2 of this
[PR](https://github.com/elastic/kibana/pull/192554). See\r\nmore info
there.\r\n\r\n<img width=\"229\" alt=\"Screenshot 2024-09-11 at 14 50
11\"\r\nsrc=\"https://github.com/user-attachments/assets/585f1ce8-2987-4355-a4b1-e13705646b48\">\r\n\r\n---------\r\n\r\nCo-authored-by:
shahzad31
<shahzad31comp@gmail.com>","sha":"244ff7b2c37f66518dbb0d7121a8d02b1405fe93","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:http","Team:Core","release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0","backport:version"],"title":"[HTTP]
Set explicit access for `public` HTTP APIs
2","number":192579,"url":"https://github.com/elastic/kibana/pull/192579","mergeCommit":{"message":"[HTTP]
Set explicit access for `public` HTTP APIs 2 (#192579)\n\n##
Summary\r\n\r\nPart 2 of this
[PR](https://github.com/elastic/kibana/pull/192554). See\r\nmore info
there.\r\n\r\n<img width=\"229\" alt=\"Screenshot 2024-09-11 at 14 50
11\"\r\nsrc=\"https://github.com/user-attachments/assets/585f1ce8-2987-4355-a4b1-e13705646b48\">\r\n\r\n---------\r\n\r\nCo-authored-by:
shahzad31
<shahzad31comp@gmail.com>","sha":"244ff7b2c37f66518dbb0d7121a8d02b1405fe93"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192579","number":192579,"mergeCommit":{"message":"[HTTP]
Set explicit access for `public` HTTP APIs 2 (#192579)\n\n##
Summary\r\n\r\nPart 2 of this
[PR](https://github.com/elastic/kibana/pull/192554). See\r\nmore info
there.\r\n\r\n<img width=\"229\" alt=\"Screenshot 2024-09-11 at 14 50
11\"\r\nsrc=\"https://github.com/user-attachments/assets/585f1ce8-2987-4355-a4b1-e13705646b48\">\r\n\r\n---------\r\n\r\nCo-authored-by:
shahzad31
<shahzad31comp@gmail.com>","sha":"244ff7b2c37f66518dbb0d7121a8d02b1405fe93"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jean-Louis Leysens <jeanlouis.leysens@elastic.co>
---
 x-pack/plugins/logstash/server/routes/pipelines/delete.ts  | 1 +
 x-pack/plugins/logstash/server/routes/pipelines/list.ts    | 1 +
 .../synthetics/server/routes/index.ts                      | 2 +-
 .../server/routes/monitor_cruds/get_monitors_list.ts       | 7 +++++--
 4 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/x-pack/plugins/logstash/server/routes/pipelines/delete.ts b/x-pack/plugins/logstash/server/routes/pipelines/delete.ts
index edf235a7357b0..8c1a6d399a9ba 100644
--- a/x-pack/plugins/logstash/server/routes/pipelines/delete.ts
+++ b/x-pack/plugins/logstash/server/routes/pipelines/delete.ts
@@ -37,6 +37,7 @@ export function registerPipelinesDeleteRoute(router: LogstashPluginRouter) {
     {
       path: '/api/logstash/pipelines/delete',
       options: {
+        access: 'public',
         summary: `Delete managed Logstash pipelines`,
       },
       validate: {
diff --git a/x-pack/plugins/logstash/server/routes/pipelines/list.ts b/x-pack/plugins/logstash/server/routes/pipelines/list.ts
index 30b4e1d08802c..1b6eaf62fb8d8 100644
--- a/x-pack/plugins/logstash/server/routes/pipelines/list.ts
+++ b/x-pack/plugins/logstash/server/routes/pipelines/list.ts
@@ -28,6 +28,7 @@ export function registerPipelinesListRoute(router: LogstashPluginRouter) {
     {
       path: '/api/logstash/pipelines',
       options: {
+        access: 'public',
         summary: `Get all managed Logstash pipelines`,
       },
       validate: false,
diff --git a/x-pack/plugins/observability_solution/synthetics/server/routes/index.ts b/x-pack/plugins/observability_solution/synthetics/server/routes/index.ts
index 75aaf9f49c4d3..48e0de1c7fba4 100644
--- a/x-pack/plugins/observability_solution/synthetics/server/routes/index.ts
+++ b/x-pack/plugins/observability_solution/synthetics/server/routes/index.ts
@@ -66,7 +66,6 @@ export const syntheticsAppRestApiRoutes: SyntheticsRestApiRouteFactory[] = [
   disableSyntheticsRoute,
   getServiceLocationsRoute,
   getSyntheticsProjectMonitorsRoute,
-  getAllSyntheticsMonitorRoute,
   installIndexTemplatesRoute,
   runOnceSyntheticsMonitorRoute,
   testNowMonitorRoute,
@@ -109,6 +108,7 @@ export const syntheticsAppPublicRestApiRoutes: SyntheticsRestApiRouteFactory[] =
   addPrivateLocationRoute,
   deletePrivateLocationRoute,
   getPrivateLocationsRoute,
+  getAllSyntheticsMonitorRoute,
   getSyntheticsMonitorRoute,
   addSyntheticsMonitorRoute,
   editSyntheticsMonitorRoute,
diff --git a/x-pack/plugins/observability_solution/synthetics/server/routes/monitor_cruds/get_monitors_list.ts b/x-pack/plugins/observability_solution/synthetics/server/routes/monitor_cruds/get_monitors_list.ts
index 22584df3a7090..62f60f6b5636c 100644
--- a/x-pack/plugins/observability_solution/synthetics/server/routes/monitor_cruds/get_monitors_list.ts
+++ b/x-pack/plugins/observability_solution/synthetics/server/routes/monitor_cruds/get_monitors_list.ts
@@ -13,8 +13,11 @@ import { syntheticsMonitorType } from '../../../common/types/saved_objects';
 export const getAllSyntheticsMonitorRoute: SyntheticsRestApiRouteFactory = () => ({
   method: 'GET',
   path: SYNTHETICS_API_URLS.SYNTHETICS_MONITORS,
-  validate: {
-    query: QuerySchema,
+  validate: {},
+  validation: {
+    request: {
+      query: QuerySchema,
+    },
   },
   handler: async (routeContext): Promise<any> => {
     const { request, savedObjectsClient, syntheticsMonitorClient } = routeContext;