From 3d99c0f3b80d38a2231bae9d341dbd639576bd41 Mon Sep 17 00:00:00 2001
From: Quynh Nguyen <quynh.nguyen@elastic.co>
Date: Wed, 23 Sep 2020 17:12:14 -0500
Subject: [PATCH] [ML] Update transform cloning to include description and new
 fields

[ML] Clean up console
---
 .../transform/public/app/common/request.ts    | 81 ++++++++++---------
 .../step_details/step_details_form.tsx        | 18 +++++
 2 files changed, 62 insertions(+), 37 deletions(-)

diff --git a/x-pack/plugins/transform/public/app/common/request.ts b/x-pack/plugins/transform/public/app/common/request.ts
index 45160d125309d..5c78e119f1979 100644
--- a/x-pack/plugins/transform/public/app/common/request.ts
+++ b/x-pack/plugins/transform/public/app/common/request.ts
@@ -134,44 +134,51 @@ export const getCreateTransformRequestBody = (
   indexPatternTitle: IndexPattern['title'],
   pivotState: StepDefineExposedState,
   transformDetailsState: StepDetailsExposedState
-): PutTransformsRequestSchema => ({
-  ...getPreviewTransformRequestBody(
-    indexPatternTitle,
-    getPivotQuery(pivotState.searchQuery),
-    dictionaryToArray(pivotState.groupByList),
-    dictionaryToArray(pivotState.aggList)
-  ),
-  // conditionally add optional description
-  ...(transformDetailsState.transformDescription !== ''
-    ? { description: transformDetailsState.transformDescription }
-    : {}),
-  // conditionally add optional frequency
-  ...(transformDetailsState.transformFrequency !== ''
-    ? { frequency: transformDetailsState.transformFrequency }
-    : {}),
-  dest: {
-    index: transformDetailsState.destinationIndex,
-  },
-  // conditionally add continuous mode config
-  ...(transformDetailsState.isContinuousModeEnabled
-    ? {
-        sync: {
-          time: {
-            field: transformDetailsState.continuousModeDateField,
-            delay: transformDetailsState.continuousModeDelay,
+): PutTransformsRequestSchema => {
+  const tempSettings = {
+    settings: {} as Record<string, number | null | undefined>,
+  };
+  if (transformDetailsState.transformSettingsMaxPageSearchSize) {
+    tempSettings.settings.max_page_search_size =
+      transformDetailsState.transformSettingsMaxPageSearchSize;
+  }
+  if (transformDetailsState.transformSettingsDocsPerSecond) {
+    tempSettings.settings.docs_per_second = transformDetailsState.transformSettingsDocsPerSecond;
+  }
+
+  return {
+    ...getPreviewTransformRequestBody(
+      indexPatternTitle,
+      getPivotQuery(pivotState.searchQuery),
+      dictionaryToArray(pivotState.groupByList),
+      dictionaryToArray(pivotState.aggList)
+    ),
+    // conditionally add optional description
+    ...(transformDetailsState.transformDescription !== ''
+      ? { description: transformDetailsState.transformDescription }
+      : {}),
+    // conditionally add optional frequency
+    ...(transformDetailsState.transformFrequency !== ''
+      ? { frequency: transformDetailsState.transformFrequency }
+      : {}),
+    dest: {
+      index: transformDetailsState.destinationIndex,
+    },
+    // conditionally add continuous mode config
+    ...(transformDetailsState.isContinuousModeEnabled
+      ? {
+          sync: {
+            time: {
+              field: transformDetailsState.continuousModeDateField,
+              delay: transformDetailsState.continuousModeDelay,
+            },
           },
-        },
-      }
-    : {}),
-  // conditionally add additional settings
-  ...(transformDetailsState.transformSettingsMaxPageSearchSize
-    ? {
-        settings: {
-          max_page_search_size: transformDetailsState.transformSettingsMaxPageSearchSize,
-        },
-      }
-    : {}),
-});
+        }
+      : {}),
+    // conditionally add additional settings
+    ...tempSettings,
+  };
+};
 
 export function isHttpFetchError(error: any): error is HttpFetchError {
   return (
diff --git a/x-pack/plugins/transform/public/app/sections/create_transform/components/step_details/step_details_form.tsx b/x-pack/plugins/transform/public/app/sections/create_transform/components/step_details/step_details_form.tsx
index 00ab516f625fe..9b43879512e4d 100644
--- a/x-pack/plugins/transform/public/app/sections/create_transform/components/step_details/step_details_form.tsx
+++ b/x-pack/plugins/transform/public/app/sections/create_transform/components/step_details/step_details_form.tsx
@@ -63,6 +63,7 @@ export interface StepDetailsExposedState {
   transformDescription: string;
   transformFrequency: string;
   transformSettingsMaxPageSearchSize: number;
+  transformSettingsDocsPerSecond?: number;
   valid: boolean;
   indexPatternTimeField?: string | undefined;
 }
@@ -100,6 +101,20 @@ export function applyTransformConfigToDetailsState(
       state.continuousModeDelay = time?.delay ?? defaultContinuousModeDelay;
       state.isContinuousModeEnabled = true;
     }
+    if (transformConfig.description !== undefined) {
+      state.transformDescription = transformConfig.description;
+    }
+    if (transformConfig.frequency !== undefined) {
+      state.transformFrequency = transformConfig.frequency;
+    }
+    if (transformConfig.settings) {
+      if (typeof transformConfig.settings?.max_page_search_size === 'number') {
+        state.transformSettingsMaxPageSearchSize = transformConfig.settings.max_page_search_size;
+      }
+      if (typeof transformConfig.settings?.docs_per_second === 'number') {
+        state.transformSettingsDocsPerSecond = transformConfig.settings.docs_per_second;
+      }
+    }
   }
   return state;
 }
@@ -275,6 +290,8 @@ export const StepDetailsForm: FC<Props> = React.memo(
     const [transformSettingsMaxPageSearchSize, setTransformSettingsMaxPageSearchSize] = useState(
       defaults.transformSettingsMaxPageSearchSize
     );
+    const [transformSettingsDocsPerSecond] = useState(defaults.transformSettingsDocsPerSecond);
+
     const isTransformSettingsMaxPageSearchSizeValid = transformSettingsMaxPageSearchSizeValidator(
       transformSettingsMaxPageSearchSize
     );
@@ -301,6 +318,7 @@ export const StepDetailsForm: FC<Props> = React.memo(
         transformDescription,
         transformFrequency,
         transformSettingsMaxPageSearchSize,
+        transformSettingsDocsPerSecond,
         destinationIndex,
         touched: true,
         valid,