From 330b3800b05d3d31a7e1079ad309479f562d49f5 Mon Sep 17 00:00:00 2001
From: Elena Shostak <165678770+elena-shostak@users.noreply.github.com>
Date: Tue, 19 Nov 2024 12:11:29 +0100
Subject: [PATCH] [FTR] Cleaned up check for removed apm_user role (#200679)

## Summary

Cleaned up check for removed `apm_user` role, see
https://github.com/elastic/elasticsearch/pull/116712


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_node:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)


__Closes:  https://github.com/elastic/kibana/issues/200666__

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
---
 x-pack/test/functional/apps/security/users.ts |  3 ---
 .../common/lib/authentication.ts              |  4 ---
 .../common/lib/create_users_and_roles.ts      | 10 --------
 .../security_and_spaces/apis/get_all.ts       | 25 -------------------
 4 files changed, 42 deletions(-)

diff --git a/x-pack/test/functional/apps/security/users.ts b/x-pack/test/functional/apps/security/users.ts
index e9711dc29c46b..a8886045b70a4 100644
--- a/x-pack/test/functional/apps/security/users.ts
+++ b/x-pack/test/functional/apps/security/users.ts
@@ -111,9 +111,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       expect(roles.apm_system.reserved).to.be(true);
       expect(roles.apm_system.deprecated).to.be(false);
 
-      expect(roles.apm_user.reserved).to.be(true);
-      expect(roles.apm_user.deprecated).to.be(true);
-
       expect(roles.beats_admin.reserved).to.be(true);
       expect(roles.beats_admin.deprecated).to.be(false);
 
diff --git a/x-pack/test/spaces_api_integration/common/lib/authentication.ts b/x-pack/test/spaces_api_integration/common/lib/authentication.ts
index 27f644c3f5cd5..cbd261008dacb 100644
--- a/x-pack/test/spaces_api_integration/common/lib/authentication.ts
+++ b/x-pack/test/spaces_api_integration/common/lib/authentication.ts
@@ -90,10 +90,6 @@ export const AUTHENTICATION = {
     username: 'a_kibana_rbac_space_1_saved_objects_read_user',
     password: 'password',
   },
-  APM_USER: {
-    username: 'a_apm_user',
-    password: 'password',
-  },
   MACHINE_LEARING_ADMIN: {
     username: 'a_machine_learning_admin',
     password: 'password',
diff --git a/x-pack/test/spaces_api_integration/common/lib/create_users_and_roles.ts b/x-pack/test/spaces_api_integration/common/lib/create_users_and_roles.ts
index 2f93cc09fd032..f917a6efed15f 100644
--- a/x-pack/test/spaces_api_integration/common/lib/create_users_and_roles.ts
+++ b/x-pack/test/spaces_api_integration/common/lib/create_users_and_roles.ts
@@ -469,16 +469,6 @@ export const createUsersAndRoles = async (es: Client, supertest: SuperTestAgent)
     },
   });
 
-  await es.security.putUser({
-    username: AUTHENTICATION.APM_USER.username,
-    body: {
-      password: AUTHENTICATION.APM_USER.password,
-      roles: ['apm_user'],
-      full_name: 'a apm user',
-      email: 'a_apm_user@elastic.co',
-    },
-  });
-
   await es.security.putUser({
     username: AUTHENTICATION.MACHINE_LEARING_ADMIN.username,
     body: {
diff --git a/x-pack/test/spaces_api_integration/security_and_spaces/apis/get_all.ts b/x-pack/test/spaces_api_integration/security_and_spaces/apis/get_all.ts
index 1c2db5f6bcd7c..d40413f9457e3 100644
--- a/x-pack/test/spaces_api_integration/security_and_spaces/apis/get_all.ts
+++ b/x-pack/test/spaces_api_integration/security_and_spaces/apis/get_all.ts
@@ -57,7 +57,6 @@ export default function getAllSpacesTestSuite({ getService }: FtrProviderContext
           legacyAll: AUTHENTICATION.KIBANA_LEGACY_USER,
           dualAll: AUTHENTICATION.KIBANA_DUAL_PRIVILEGES_USER,
           dualRead: AUTHENTICATION.KIBANA_DUAL_PRIVILEGES_DASHBOARD_ONLY_USER,
-          apmUser: AUTHENTICATION.APM_USER,
           machineLearningAdmin: AUTHENTICATION.MACHINE_LEARING_ADMIN,
           machineLearningUser: AUTHENTICATION.MACHINE_LEARNING_USER,
           monitoringUser: AUTHENTICATION.MONITORING_USER,
@@ -83,7 +82,6 @@ export default function getAllSpacesTestSuite({ getService }: FtrProviderContext
           legacyAll: AUTHENTICATION.KIBANA_LEGACY_USER,
           dualAll: AUTHENTICATION.KIBANA_DUAL_PRIVILEGES_USER,
           dualRead: AUTHENTICATION.KIBANA_DUAL_PRIVILEGES_DASHBOARD_ONLY_USER,
-          apmUser: AUTHENTICATION.APM_USER,
           machineLearningAdmin: AUTHENTICATION.MACHINE_LEARING_ADMIN,
           machineLearningUser: AUTHENTICATION.MACHINE_LEARNING_USER,
           monitoringUser: AUTHENTICATION.MONITORING_USER,
@@ -484,29 +482,6 @@ export default function getAllSpacesTestSuite({ getService }: FtrProviderContext
         }
       );
 
-      getAllTest(`apm_user can't access any spaces from ${scenario.spaceId}`, {
-        spaceId: scenario.spaceId,
-        user: scenario.users.apmUser,
-        tests: {
-          exists: {
-            statusCode: 403,
-            response: expectRbacForbidden,
-          },
-          copySavedObjectsPurpose: {
-            statusCode: 403,
-            response: expectRbacForbidden,
-          },
-          shareSavedObjectsPurpose: {
-            statusCode: 403,
-            response: expectRbacForbidden,
-          },
-          includeAuthorizedPurposes: {
-            statusCode: 403,
-            response: expectRbacForbidden,
-          },
-        },
-      });
-
       getAllTest(`machine_learning_admin can't access any spaces from ${scenario.spaceId}`, {
         spaceId: scenario.spaceId,
         user: scenario.users.machineLearningAdmin,