From 1ee6820edc5857230c01a6f0fe09c8f128164952 Mon Sep 17 00:00:00 2001 From: Wylie Conlon Date: Wed, 6 May 2020 13:49:30 -0400 Subject: [PATCH] Update from feedback --- .../lens/public/pie_visualization/render_function.tsx | 6 +++++- .../lens/public/pie_visualization/settings_widget.tsx | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/x-pack/plugins/lens/public/pie_visualization/render_function.tsx b/x-pack/plugins/lens/public/pie_visualization/render_function.tsx index f451a6b74e299..0c27a3e4b44e3 100644 --- a/x-pack/plugins/lens/public/pie_visualization/render_function.tsx +++ b/x-pack/plugins/lens/public/pie_visualization/render_function.tsx @@ -109,7 +109,10 @@ export function PieComponent( return String(d); }, fillLabel: - isDarkMode && shape === 'treemap' && layerIndex < columnGroups.length - 1 + isDarkMode && + shape === 'treemap' && + layerIndex < columnGroups.length - 1 && + categoryDisplay !== 'hide' ? { ...fillLabel, textColor: euiDarkVars.euiTextColor } : fillLabel, shape: { @@ -252,6 +255,7 @@ export function PieComponent( valueFormatter={(d: number) => (hideLabels ? '' : formatters[metricColumn.id].convert(d))} layers={layers} config={config} + topGroove={hideLabels || categoryDisplay === 'hide' ? 0 : undefined} /> diff --git a/x-pack/plugins/lens/public/pie_visualization/settings_widget.tsx b/x-pack/plugins/lens/public/pie_visualization/settings_widget.tsx index bdc4df39f2e4f..bb63ceceb2b1b 100644 --- a/x-pack/plugins/lens/public/pie_visualization/settings_widget.tsx +++ b/x-pack/plugins/lens/public/pie_visualization/settings_widget.tsx @@ -73,7 +73,7 @@ const categoryOptionsTreemap: Array<{ { value: 'default', inputDisplay: i18n.translate('xpack.lens.pieChart.showTreemapCategoriesLabel', { - defaultMessage: 'Show', + defaultMessage: 'Show labels', }), }, {