From 1cf8b9dfd145500e3dd09235b05c8f94032510d7 Mon Sep 17 00:00:00 2001
From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Date: Sat, 26 Oct 2024 03:41:39 +1100
Subject: [PATCH] [8.x] [ML] Update allocations tooltip to clarify that
 it&#x27;s per node (#197099) (#197846)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] Update allocations tooltip to clarify that it&#x27;s per node
(#197099)](https://github.com/elastic/kibana/pull/197099)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Liam
Thompson","email":"32779855+leemthompo@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-23T15:30:13Z","message":"[ML]
Update allocations tooltip to clarify that it's per node
(#197099)\n\nClarifies text to mention nodes, conditional on being
not-serverless","sha":"ea4ce57141019606b148016f667dd7a0cf98ff8c","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","v9.0.0","Team:ML","v8.16.0","backport:version","v8.17.0"],"title":"[ML]
Update allocations tooltip to clarify that it's per
node","number":197099,"url":"https://github.com/elastic/kibana/pull/197099","mergeCommit":{"message":"[ML]
Update allocations tooltip to clarify that it's per node
(#197099)\n\nClarifies text to mention nodes, conditional on being
not-serverless","sha":"ea4ce57141019606b148016f667dd7a0cf98ff8c"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197099","number":197099,"mergeCommit":{"message":"[ML]
Update allocations tooltip to clarify that it's per node
(#197099)\n\nClarifies text to mention nodes, conditional on being
not-serverless","sha":"ea4ce57141019606b148016f667dd7a0cf98ff8c"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/197488","number":197488,"state":"MERGED","mergeCommit":{"sha":"3d98f6c3f7cdca73d184b8d5b6a103e7fcdfe779","message":"[8.16]
[ML] Update allocations tooltip to clarify that it is per node (#197099)
(#197488)\n\n# Backport\n\nThis will backport the following commits from
`main` to `8.16`:\n- [[ML] Update allocations tooltip to clarify that
it&#x27;s per
node\n(#197099)](https://github.com/elastic/kibana/pull/197099)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Liam\nThompson\",\"email\":\"32779855+leemthompo@users.noreply.github.com\"},\"sourceCommit\":{\"committedDate\":\"2024-10-23T15:30:13Z\",\"message\":\"[ML]\nUpdate
allocations tooltip to clarify that it's per
node\n(#197099)\\n\\nClarifies text to mention nodes, conditional on
being\nnot-serverless\",\"sha\":\"ea4ce57141019606b148016f667dd7a0cf98ff8c\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\":ml\",\"release_note:skip\",\"v9.0.0\",\"Team:ML\",\"v8.16.0\",\"backport:version\"],\"title\":\"[ML]\nUpdate
allocations tooltip to clarify that it's
per\nnode\",\"number\":197099,\"url\":\"https://github.com/elastic/kibana/pull/197099\",\"mergeCommit\":{\"message\":\"[ML]\nUpdate
allocations tooltip to clarify that it's per
node\n(#197099)\\n\\nClarifies text to mention nodes, conditional on
being\nnot-serverless\",\"sha\":\"ea4ce57141019606b148016f667dd7a0cf98ff8c\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.16\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/197099\",\"number\":197099,\"mergeCommit\":{\"message\":\"[ML]\nUpdate
allocations tooltip to clarify that it's per
node\n(#197099)\\n\\nClarifies text to mention nodes, conditional on
being\nnot-serverless\",\"sha\":\"ea4ce57141019606b148016f667dd7a0cf98ff8c\"}},{\"branch\":\"8.16\",\"label\":\"v8.16.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by:
Liam Thompson
<32779855+leemthompo@users.noreply.github.com>"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
---
 .../nodes_overview/allocated_models.tsx       | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

diff --git a/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/allocated_models.tsx b/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/allocated_models.tsx
index bce892a26b678..4dd04780e2e92 100644
--- a/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/allocated_models.tsx
+++ b/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/allocated_models.tsx
@@ -24,6 +24,7 @@ import type {
   NodeDeploymentStatsResponse,
 } from '../../../../common/types/trained_models';
 import { useFieldFormatter } from '../../contexts/kibana/use_field_formatter';
+import { useEnabledFeatures } from '../../contexts/ml';
 
 interface AllocatedModelsProps {
   models: NodeDeploymentStatsResponse['allocated_models'];
@@ -38,6 +39,7 @@ export const AllocatedModels: FC<AllocatedModelsProps> = ({
   const dateFormatter = useFieldFormatter(FIELD_FORMAT_IDS.DATE);
   const durationFormatter = useFieldFormatter(FIELD_FORMAT_IDS.DURATION);
   const euiTheme = useEuiTheme();
+  const { showNodeInfo } = useEnabledFeatures();
 
   const columns: Array<EuiBasicTableColumn<AllocatedModel>> = [
     {
@@ -105,9 +107,20 @@ export const AllocatedModels: FC<AllocatedModelsProps> = ({
       width: '8%',
       name: (
         <EuiToolTip
-          content={i18n.translate('xpack.ml.trainedModels.nodesList.modelsList.allocationTooltip', {
-            defaultMessage: 'number_of_allocations times threads_per_allocation',
-          })}
+          content={
+            showNodeInfo
+              ? i18n.translate(
+                  'xpack.ml.trainedModels.nodesList.modelsList.allocationTooltipNodes',
+                  {
+                    defaultMessage:
+                      'Number of allocations per node multiplied by number of threads per allocation',
+                  }
+                )
+              : i18n.translate('xpack.ml.trainedModels.nodesList.modelsList.allocationTooltip', {
+                  defaultMessage:
+                    'Number of allocations multiplied by number of threads per allocation',
+                })
+          }
         >
           <span>
             {i18n.translate('xpack.ml.trainedModels.nodesList.modelsList.allocationHeader', {