From 1b315bb01d6b97793c6993d08e04789f5aaaa4bd Mon Sep 17 00:00:00 2001
From: Anton Dosov <anton.dosov@elastic.co>
Date: Mon, 2 Aug 2021 12:59:56 +0200
Subject: [PATCH] [Lens] Fix suffix field format leaks to index pattern
 management (#107139)

---
 x-pack/plugins/lens/common/suffix_formatter/index.ts       | 1 +
 .../lens/common/suffix_formatter/suffix_formatter.test.ts  | 7 +++++++
 2 files changed, 8 insertions(+)

diff --git a/x-pack/plugins/lens/common/suffix_formatter/index.ts b/x-pack/plugins/lens/common/suffix_formatter/index.ts
index 12a4e02a81ef2..97fa8c067331e 100644
--- a/x-pack/plugins/lens/common/suffix_formatter/index.ts
+++ b/x-pack/plugins/lens/common/suffix_formatter/index.ts
@@ -31,6 +31,7 @@ export const unitSuffixesLong: Record<TimeScaleUnit, string> = {
 export function getSuffixFormatter(formatFactory: FormatFactory): FieldFormatInstanceType {
   return class SuffixFormatter extends FieldFormat {
     static id = 'suffix';
+    static hidden = true; // Don't want this format to appear in index pattern editor
     static title = i18n.translate('xpack.lens.fieldFormats.suffix.title', {
       defaultMessage: 'Suffix',
     });
diff --git a/x-pack/plugins/lens/common/suffix_formatter/suffix_formatter.test.ts b/x-pack/plugins/lens/common/suffix_formatter/suffix_formatter.test.ts
index c4379bdd1fb34..d08908ecde417 100644
--- a/x-pack/plugins/lens/common/suffix_formatter/suffix_formatter.test.ts
+++ b/x-pack/plugins/lens/common/suffix_formatter/suffix_formatter.test.ts
@@ -42,4 +42,11 @@ describe('suffix formatter', () => {
 
     expect(result).toEqual('');
   });
+
+  it('should be a hidden formatter', () => {
+    const convertMock = jest.fn((x) => '');
+    const formatFactory = jest.fn(() => ({ convert: convertMock }));
+    const SuffixFormatter = getSuffixFormatter((formatFactory as unknown) as FormatFactory);
+    expect(SuffixFormatter.hidden).toBe(true);
+  });
 });