From 10535f0b90488b4e630b0fb071b34a66b47ce39c Mon Sep 17 00:00:00 2001
From: Nathan Reese <reese.nathan@gmail.com>
Date: Thu, 14 Nov 2019 20:20:22 -0700
Subject: [PATCH] [Maps] prevent users from overflowing URL when filtering by
 shape

---
 src/legacy/ui/public/url/index.js             |  2 +-
 .../geometry_filter_form.test.js.snap         | 82 +++++++++++++++++++
 .../public/components/geometry_filter_form.js |  8 ++
 .../components/geometry_filter_form.test.js   | 19 +++++
 .../feature_geometry_filter_form.js           | 19 +++++
 5 files changed, 129 insertions(+), 1 deletion(-)

diff --git a/src/legacy/ui/public/url/index.js b/src/legacy/ui/public/url/index.js
index a8f7b5fed350c..f3beb05e577c1 100644
--- a/src/legacy/ui/public/url/index.js
+++ b/src/legacy/ui/public/url/index.js
@@ -19,4 +19,4 @@
 
 export { KbnUrlProvider } from './url';
 export { RedirectWhenMissingProvider } from './redirect_when_missing';
-export { modifyUrl } from '../../../../core/public/utils';
+export { modifyUrl } from '../../../../core/utils';
diff --git a/x-pack/legacy/plugins/maps/public/components/__snapshots__/geometry_filter_form.test.js.snap b/x-pack/legacy/plugins/maps/public/components/__snapshots__/geometry_filter_form.test.js.snap
index 0205519674be3..98e6fa0517f58 100644
--- a/x-pack/legacy/plugins/maps/public/components/__snapshots__/geometry_filter_form.test.js.snap
+++ b/x-pack/legacy/plugins/maps/public/components/__snapshots__/geometry_filter_form.test.js.snap
@@ -188,6 +188,88 @@ exports[`should not show "within" relation when filter geometry is not closed 1`
 </EuiForm>
 `;
 
+exports[`should render error message 1`] = `
+<EuiForm>
+  <EuiFormRow
+    describedByIds={Array []}
+    display="rowCompressed"
+    fullWidth={false}
+    hasChildLabel={true}
+    hasEmptyLabelSpace={false}
+    label="Geometry label"
+    labelType="label"
+  >
+    <EuiFieldText
+      compressed={true}
+      fullWidth={false}
+      isLoading={false}
+      onChange={[Function]}
+      value="My shape"
+    />
+  </EuiFormRow>
+  <EuiFormRow
+    className="mapGeometryFilter__geoFieldSuperSelectWrapper"
+    describedByIds={Array []}
+    display="rowCompressed"
+    fullWidth={false}
+    hasChildLabel={true}
+    hasEmptyLabelSpace={false}
+    label="Filtered field"
+    labelType="label"
+  >
+    <EuiSuperSelect
+      className="mapGeometryFilter__geoFieldSuperSelect"
+      compressed={true}
+      fullWidth={true}
+      hasDividers={true}
+      isInvalid={false}
+      itemClassName="mapGeometryFilter__geoFieldItem"
+      onChange={[Function]}
+      options={
+        Array [
+          Object {
+            "inputDisplay": <EuiText
+              component="span"
+              size="s"
+            >
+              <EuiTextColor
+                color="subdued"
+              >
+                <small>
+                  My index
+                </small>
+              </EuiTextColor>
+              <br />
+              my geo field
+            </EuiText>,
+            "value": "My index/my geo field",
+          },
+        ]
+      }
+      valueOfSelected="My index/my geo field"
+    />
+  </EuiFormRow>
+  <EuiSpacer
+    size="m"
+  />
+  <EuiFormErrorText>
+    Simulated error
+  </EuiFormErrorText>
+  <EuiTextAlign
+    textAlign="right"
+  >
+    <EuiButton
+      fill={true}
+      isDisabled={false}
+      onClick={[Function]}
+      size="s"
+    >
+      Create filter
+    </EuiButton>
+  </EuiTextAlign>
+</EuiForm>
+`;
+
 exports[`should render relation select when geo field is geo_shape 1`] = `
 <EuiForm>
   <EuiFormRow
diff --git a/x-pack/legacy/plugins/maps/public/components/geometry_filter_form.js b/x-pack/legacy/plugins/maps/public/components/geometry_filter_form.js
index 767237ecdf38d..c84970b5f7b2c 100644
--- a/x-pack/legacy/plugins/maps/public/components/geometry_filter_form.js
+++ b/x-pack/legacy/plugins/maps/public/components/geometry_filter_form.js
@@ -17,6 +17,7 @@ import {
   EuiSelect,
   EuiSpacer,
   EuiTextAlign,
+  EuiFormErrorText,
 } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
 import { ES_GEO_FIELD_TYPE, ES_SPATIAL_RELATIONS } from '../../common/constants';
@@ -43,6 +44,7 @@ export class GeometryFilterForm extends Component {
     intitialGeometryLabel: PropTypes.string.isRequired,
     onSubmit: PropTypes.func.isRequired,
     isFilterGeometryClosed: PropTypes.bool,
+    errorMsg: PropTypes.string,
   };
 
   static defaultProps = {
@@ -153,6 +155,10 @@ export class GeometryFilterForm extends Component {
         value: createIndexGeoFieldName({ indexPatternTitle, geoFieldName }),
       };
     });
+    let error;
+    if (this.props.errorMsg) {
+      error = <EuiFormErrorText>{this.props.errorMsg}</EuiFormErrorText>;
+    }
     return (
       <EuiForm className={this.props.className}>
         <EuiFormRow
@@ -191,6 +197,8 @@ export class GeometryFilterForm extends Component {
 
         <EuiSpacer size="m" />
 
+        {error}
+
         <EuiTextAlign textAlign="right">
           <EuiButton
             size="s"
diff --git a/x-pack/legacy/plugins/maps/public/components/geometry_filter_form.test.js b/x-pack/legacy/plugins/maps/public/components/geometry_filter_form.test.js
index b1e679591aa6a..980c30d69cb7a 100644
--- a/x-pack/legacy/plugins/maps/public/components/geometry_filter_form.test.js
+++ b/x-pack/legacy/plugins/maps/public/components/geometry_filter_form.test.js
@@ -69,3 +69,22 @@ test('should not show "within" relation when filter geometry is not closed', asy
 
   expect(component).toMatchSnapshot();
 });
+
+test('should render error message', async () => {
+  const component = shallow(
+    <GeometryFilterForm
+      {...defaultProps}
+      geoFields={[
+        {
+          geoFieldName: 'my geo field',
+          geoFieldType: 'geo_point',
+          indexPatternTitle: 'My index',
+          indexPatternId: 1
+        }
+      ]}
+      errorMsg="Simulated error"
+    />
+  );
+
+  expect(component).toMatchSnapshot();
+});
diff --git a/x-pack/legacy/plugins/maps/public/connected_components/map/features_tooltip/feature_geometry_filter_form.js b/x-pack/legacy/plugins/maps/public/connected_components/map/features_tooltip/feature_geometry_filter_form.js
index b5029407d4786..cfc8221a64c5e 100644
--- a/x-pack/legacy/plugins/maps/public/connected_components/map/features_tooltip/feature_geometry_filter_form.js
+++ b/x-pack/legacy/plugins/maps/public/connected_components/map/features_tooltip/feature_geometry_filter_form.js
@@ -11,11 +11,14 @@ import { i18n } from '@kbn/i18n';
 import { createSpatialFilterWithGeometry } from '../../../elasticsearch_geo_utils';
 import { GEO_JSON_TYPE } from '../../../../common/constants';
 import { GeometryFilterForm } from '../../../components/geometry_filter_form';
+import { UrlOverflowService } from 'ui/error_url_overflow';
+import rison from 'rison-node';
 
 export class FeatureGeometryFilterForm extends Component {
 
   state = {
     isLoading: false,
+    errorMsg: undefined,
   }
 
   componentDidMount() {
@@ -46,6 +49,7 @@ export class FeatureGeometryFilterForm extends Component {
   }
 
   _createFilter = async ({ geometryLabel, indexPatternId, geoFieldName, geoFieldType, relation }) => {
+    this.setState({ errorMsg: undefined });
     const preIndexedShape = await this._loadPreIndexedShape();
     if (!this._isMounted) {
       // do not create filter if component is unmounted
@@ -61,6 +65,20 @@ export class FeatureGeometryFilterForm extends Component {
       geoFieldType,
       relation,
     });
+
+    // When filter contains geometry, ensure filter will not overflow URL
+    if (!preIndexedShape) {
+      const urlOverflow = new UrlOverflowService();
+      if (window.location.href.length + rison.encode(filter).length > urlOverflow.failLength()) {
+        this.setState({
+          errorMsg: i18n.translate('xpack.maps.tooltip.geometryFilterForm.filterTooLargeMessage', {
+            defaultMessage: 'Unable to create filter, too many vertices in shape.'
+          })
+        });
+        return;
+      }
+    }
+
     this.props.addFilters([filter]);
     this.props.onClose();
   }
@@ -102,6 +120,7 @@ export class FeatureGeometryFilterForm extends Component {
         isFilterGeometryClosed={this.props.geometry.type !== GEO_JSON_TYPE.LINE_STRING
           && this.props.geometry.type !== GEO_JSON_TYPE.MULTI_LINE_STRING}
         isLoading={this.state.isLoading}
+        errorMsg={this.state.errorMsg}
       />
     );
   }