From 0bed14afe0e5171c5a9cf1f6f6ed1474ba17af9d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Cau=C3=AA=20Marcondes?=
 <55978943+cauemarcondes@users.noreply.github.com>
Date: Thu, 7 May 2020 12:21:06 +0100
Subject: [PATCH] [APM] Remove link from active page in the breadcrumb (#65473)
 (#65625)

---
 .../{__test__ => }/ProvideBreadcrumbs.test.tsx   |  4 ++--
 .../components/app/Main/UpdateBreadcrumbs.tsx    | 16 ++++++++++++----
 .../UpdateBreadcrumbs.test.tsx.snap              | 10 +++++-----
 3 files changed, 19 insertions(+), 11 deletions(-)
 rename x-pack/plugins/apm/public/components/app/Main/{__test__ => }/ProvideBreadcrumbs.test.tsx (94%)

diff --git a/x-pack/plugins/apm/public/components/app/Main/__test__/ProvideBreadcrumbs.test.tsx b/x-pack/plugins/apm/public/components/app/Main/ProvideBreadcrumbs.test.tsx
similarity index 94%
rename from x-pack/plugins/apm/public/components/app/Main/__test__/ProvideBreadcrumbs.test.tsx
rename to x-pack/plugins/apm/public/components/app/Main/ProvideBreadcrumbs.test.tsx
index cb983cdffa028..1e3a73acfab57 100644
--- a/x-pack/plugins/apm/public/components/app/Main/__test__/ProvideBreadcrumbs.test.tsx
+++ b/x-pack/plugins/apm/public/components/app/Main/ProvideBreadcrumbs.test.tsx
@@ -5,8 +5,8 @@
  */
 
 import { Location } from 'history';
-import { BreadcrumbRoute, getBreadcrumbs } from '../ProvideBreadcrumbs';
-import { RouteName } from '../route_config/route_names';
+import { BreadcrumbRoute, getBreadcrumbs } from './ProvideBreadcrumbs';
+import { RouteName } from './route_config/route_names';
 
 describe('getBreadcrumbs', () => {
   const getTestRoutes = (): BreadcrumbRoute[] => [
diff --git a/x-pack/plugins/apm/public/components/app/Main/UpdateBreadcrumbs.tsx b/x-pack/plugins/apm/public/components/app/Main/UpdateBreadcrumbs.tsx
index 8960af0f21fd2..b4a556c497c1b 100644
--- a/x-pack/plugins/apm/public/components/app/Main/UpdateBreadcrumbs.tsx
+++ b/x-pack/plugins/apm/public/components/app/Main/UpdateBreadcrumbs.tsx
@@ -30,10 +30,18 @@ function getTitleFromBreadCrumbs(breadcrumbs: Breadcrumb[]) {
 
 class UpdateBreadcrumbsComponent extends React.Component<Props> {
   public updateHeaderBreadcrumbs() {
-    const breadcrumbs = this.props.breadcrumbs.map(({ value, match }) => ({
-      text: value,
-      href: getAPMHref(match.url, this.props.location.search)
-    }));
+    const breadcrumbs = this.props.breadcrumbs.map(
+      ({ value, match }, index) => {
+        const isLastBreadcrumbItem =
+          index === this.props.breadcrumbs.length - 1;
+        return {
+          text: value,
+          href: isLastBreadcrumbItem
+            ? undefined // makes the breadcrumb item not clickable
+            : getAPMHref(match.url, this.props.location.search)
+        };
+      }
+    );
 
     document.title = getTitleFromBreadCrumbs(this.props.breadcrumbs);
     this.props.core.chrome.setBreadcrumbs(breadcrumbs);
diff --git a/x-pack/plugins/apm/public/components/app/Main/__snapshots__/UpdateBreadcrumbs.test.tsx.snap b/x-pack/plugins/apm/public/components/app/Main/__snapshots__/UpdateBreadcrumbs.test.tsx.snap
index 51bdb63874e63..e7f6cba59318a 100644
--- a/x-pack/plugins/apm/public/components/app/Main/__snapshots__/UpdateBreadcrumbs.test.tsx.snap
+++ b/x-pack/plugins/apm/public/components/app/Main/__snapshots__/UpdateBreadcrumbs.test.tsx.snap
@@ -15,7 +15,7 @@ Array [
     "text": "opbeans-node",
   },
   Object {
-    "href": "#/services/opbeans-node/errors?rangeFrom=now-24h&rangeTo=now&refreshPaused=true&refreshInterval=0&kuery=myKuery",
+    "href": undefined,
     "text": "Errors",
   },
 ]
@@ -40,7 +40,7 @@ Array [
     "text": "Errors",
   },
   Object {
-    "href": "#/services/opbeans-node/errors/myGroupId?rangeFrom=now-24h&rangeTo=now&refreshPaused=true&refreshInterval=0&kuery=myKuery",
+    "href": undefined,
     "text": "myGroupId",
   },
 ]
@@ -61,7 +61,7 @@ Array [
     "text": "opbeans-node",
   },
   Object {
-    "href": "#/services/opbeans-node/transactions?rangeFrom=now-24h&rangeTo=now&refreshPaused=true&refreshInterval=0&kuery=myKuery",
+    "href": undefined,
     "text": "Transactions",
   },
 ]
@@ -86,7 +86,7 @@ Array [
     "text": "Transactions",
   },
   Object {
-    "href": "#/services/opbeans-node/transactions/view?rangeFrom=now-24h&rangeTo=now&refreshPaused=true&refreshInterval=0&kuery=myKuery",
+    "href": undefined,
     "text": "my-transaction-name",
   },
 ]
@@ -95,7 +95,7 @@ Array [
 exports[`UpdateBreadcrumbs Homepage 1`] = `
 Array [
   Object {
-    "href": "#/?rangeFrom=now-24h&rangeTo=now&refreshPaused=true&refreshInterval=0&kuery=myKuery",
+    "href": undefined,
     "text": "APM",
   },
 ]