From 095f5963ac91edde308774cd2e8c0d8391e065a5 Mon Sep 17 00:00:00 2001
From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Date: Thu, 17 Nov 2022 03:24:07 -0500
Subject: [PATCH] [8.6] Don't show "You have not been authorized to create any
 Rule types" message while request to get rule types is in flight (#145407)
 (#145506)

# Backport

This will backport the following commits from `main` to `8.6`:
- [Don't show "You have not been authorized to create any Rule types"
message while request to get rule types is in flight
(#145407)](https://github.com/elastic/kibana/pull/145407)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Coen
Warmer","email":"coen.warmer@gmail.com"},"sourceCommit":{"committedDate":"2022-11-17T07:19:07Z","message":"Don't
show \"You have not been authorized to create any Rule types\" message
while request to get rule types is in flight
(#145407)","sha":"e01649e7b23d9bb0b855b2ba2081ae72cc49f815","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Team:
Actionable
Observability","v8.6.0","v8.7.0"],"number":145407,"url":"https://github.com/elastic/kibana/pull/145407","mergeCommit":{"message":"Don't
show \"You have not been authorized to create any Rule types\" message
while request to get rule types is in flight
(#145407)","sha":"e01649e7b23d9bb0b855b2ba2081ae72cc49f815"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145407","number":145407,"mergeCommit":{"message":"Don't
show \"You have not been authorized to create any Rule types\" message
while request to get rule types is in flight
(#145407)","sha":"e01649e7b23d9bb0b855b2ba2081ae72cc49f815"}}]}]
BACKPORT-->

Co-authored-by: Coen Warmer <coen.warmer@gmail.com>
---
 .../public/application/sections/rule_form/rule_form.tsx      | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/x-pack/plugins/triggers_actions_ui/public/application/sections/rule_form/rule_form.tsx b/x-pack/plugins/triggers_actions_ui/public/application/sections/rule_form/rule_form.tsx
index ed2b6c27a0604..d37e41ff26555 100644
--- a/x-pack/plugins/triggers_actions_ui/public/application/sections/rule_form/rule_form.tsx
+++ b/x-pack/plugins/triggers_actions_ui/public/application/sections/rule_form/rule_form.tsx
@@ -169,6 +169,7 @@ export const RuleForm = ({
     ruleTypes,
     error: loadRuleTypesError,
     ruleTypeIndex,
+    ruleTypesIsLoading,
   } = useLoadRuleTypes({ filteredRuleTypes: ruleTypeToFilter });
 
   // load rule types
@@ -848,7 +849,7 @@ export const RuleForm = ({
           ) : null}
           {ruleTypeNodes}
         </>
-      ) : ruleTypeIndex ? (
+      ) : ruleTypeIndex && !ruleTypesIsLoading ? (
         <NoAuthorizedRuleTypes operation={operation} />
       ) : (
         <SectionLoading>
@@ -871,7 +872,7 @@ const NoAuthorizedRuleTypes = ({ operation }: { operation: string }) => (
       <h2>
         <FormattedMessage
           id="xpack.triggersActionsUI.sections.ruleForm.error.noAuthorizedRuleTypesTitle"
-          defaultMessage="You have not been authorized to {operation} any Rule types"
+          defaultMessage="You have not been authorized to {operation} any rule types"
           values={{ operation }}
         />
       </h2>