Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws,aws_logs] Variable shadowing for proxy_url and number_of_workers #6148

Open
andrewkroh opened this issue May 10, 2023 · 2 comments
Open
Labels
Integration:aws_logs Custom AWS Logs Integration:aws AWS Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Comments

@andrewkroh
Copy link
Member

andrewkroh commented May 10, 2023

Variables are declare more than once in the context of a stream. This can lead to confusion for users since the same variable can be configured at multiple places and it is not clear which one takes precedence. Also in each case here the two variables have slightly different descriptions.

duplicate variable "proxy_url" found at both

- name: proxy_url

duplicate variable "proxy_url" found at both

- name: proxy_url

duplicate variable "proxy_url" found at both

- name: proxy_url

duplicate variable "number_of_workers" found at both ( ✅ FIXED)


@botelastic
Copy link

botelastic bot commented May 9, 2024

Hi! We just realized that we haven't looked into this issue in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label May 9, 2024
@andrewkroh
Copy link
Member Author

andrewkroh commented May 9, 2024

The aws_logs shadowing of number_of_workers has been addressed via #7319. But the other issues within the aws integration still remain.

@botelastic botelastic bot removed the Stalled label May 9, 2024
@andrewkroh andrewkroh added Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] and removed Team:Cloud-Monitoring Label for the Cloud Monitoring team labels May 9, 2024
@andrewkroh andrewkroh added the Integration:aws_logs Custom AWS Logs label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:aws_logs Custom AWS Logs Integration:aws AWS Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

No branches or pull requests

1 participant