Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Kibana test suite when Stack Monitoring integrations change #4932

Closed
miltonhultgren opened this issue Jan 4, 2023 · 1 comment
Closed
Labels
Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services

Comments

@miltonhultgren
Copy link
Contributor

miltonhultgren commented Jan 4, 2023

Summary

In elastic/kibana#146000 we added a test setup inside the Kibana repo to allow us to test that the Stack Monitoring UI app works with an unreleased version of a related Integration (Elasticsearch, Kibana, Logstash, Beat).

The downside to that setup is that it requires a manual step of building the package, copying the zip file into Kibana and executing the test suites and if those tests fail they still don't block the merger of the changes to the Integration.

It would be better, if when a PR is opened to one of these integrations, tests could be run for the components that depend on those integrations (in this case, Kibana). So a CI build for the Elasticsearch Integration, would pull down the latest Kibana version from source and run the affected test suites, if any test fails, the CI build fails and the PR is blocked.
The PR can become unblocked if changes are made to Kibana to support the new (and old) formats of the data for example.

Questions

  • How can we make the latest package build available to the Kibana ?
  • How can we provide the dynamic package configuration to Kibana ? Right now it's hardcoded
  • Should we run this verification against main ? all supported minors ?
  • How can we create a CI step that only runs for a specific package ? How to parametrize the CI step with the package under test ?
@miltonhultgren miltonhultgren added the Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services label Jan 4, 2023
@klacabane
Copy link
Contributor

This is blocked by elastic/kibana#148303, but one could experiment with the Beats test suite

@smith smith closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services
Projects
None yet
Development

No branches or pull requests

3 participants