Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more details about the use of metrics metadata to the documentation #4124

Open
jsoriano opened this issue Sep 5, 2022 · 7 comments
Open
Assignees
Labels
documentation Improvements or additions to documentation Stalled

Comments

@jsoriano
Copy link
Member

jsoriano commented Sep 5, 2022

Generic guidelines mention the specification of metric types, units and dimensions, but it would be useful for package developers to have more detailed information about the implications of these fields, regarding having them vs. not having them vs. wrongly having them.

@ruflin
Copy link
Contributor

ruflin commented Dec 5, 2022

@jsoriano Any updates on this. I started to play around with this in #4749 mostly around dimensions. I think we need an overall recommendation guide on what to use when.

@endorama
Copy link
Member

Have there been any updates here? Aligning packages would help with consistency and would allow for other workflows to be built on top of these information.

@jsoriano
Copy link
Member Author

@ruflin @endorama I have started a PR so we have some progress on this, let's iterate there: #5270 Suggestions welcome.

@ruflin
Copy link
Contributor

ruflin commented Feb 15, 2023

@agithomas @lalit-satapathy For awareness as you are also working on this.

@jsoriano
Copy link
Member Author

#5270 with some additional general guidelines merged, @agithomas is working on a more detailed guide in #5355.

@jsoriano jsoriano removed their assignment Feb 23, 2023
@lalit-satapathy
Copy link
Collaborator

@agithomas,

What is pending on this issue. For example, we can see metric types in docs now:

Screenshot 2023-12-01 at 12 39 03 PM

@botelastic
Copy link

botelastic bot commented Nov 30, 2024

Hi! We just realized that we haven't looked into this issue in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Stalled
Projects
None yet
Development

No branches or pull requests

5 participants