Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question]: Default time unit for Ignore events older than under datasets for System integration. #3972

Open
amolnater-qasource opened this issue Aug 9, 2022 · 7 comments
Labels
Integration:system System question Further information is requested Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team [elastic/elastic-agent-data-plane]

Comments

@amolnater-qasource
Copy link

Description:
While validating #3149 we have observed that we are able to save Ignore events older than field with no time units( "ns", "us" (or "µs"), "ms", "s", "m", "h") defined.

Question:
If user saves this field with only numerical data, could you please confirm what would be the default time unit for Ignore events older than field?

Screen Recording:

Edit.integration.-.Agent.policy.1.-.Agent.policies.-.Fleet.-.Elastic.-.Google.Chrome.2022-08-09.13-30-11.mp4
@amolnater-qasource amolnater-qasource added question Further information is requested release-pending Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team [elastic/elastic-agent-data-plane] labels Aug 9, 2022
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@amolnater-qasource
Copy link
Author

@manishgupta-qasource Please review.

@manishgupta-qasource
Copy link

Secondary review for this ticket is Done

@faec
Copy link

faec commented Aug 9, 2022

The underlying type of this field is Duration which is used throughout beats config, however the documentation says that type requires a unit, and I don't think I've seen it without one, so the fact that this is even possible is probably a bug.

@jen-huang
Copy link
Contributor

@faec We don't support validation of a "duration" type in the UI (not supported in the package spec either for user-inputted vars). Would be a good enhancement for sure, but do you know what the effect would be if the unit is omitted in the meantime?

@botelastic
Copy link

botelastic bot commented Aug 10, 2023

Hi! We just realized that we haven't looked into this issue in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Aug 10, 2023
@amolnater-qasource
Copy link
Author

Hi @juliaElastic
Could you please share if there's any update on the same.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:system System question Further information is requested Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team [elastic/elastic-agent-data-plane]
Projects
None yet
Development

No branches or pull requests

6 participants