Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple config for datasource #361

Merged
merged 5 commits into from
Apr 22, 2020
Merged

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Apr 21, 2020

Some datasources can only be installed once per agent config. An example for this is the endpoint datasource. This introduces the multiple:false flag on the datasource level

Some datasources can only be installed once per agent config. An example for this is the endpoint datasource. This introduces the multiple:false flag on the datasource level
@ruflin ruflin self-assigned this Apr 21, 2020
@ruflin ruflin requested a review from jen-huang April 21, 2020 12:23
@ruflin
Copy link
Contributor Author

ruflin commented Apr 22, 2020

@mtojek This might have some effects on the generator.

CHANGELOG.md Outdated
@@ -22,6 +22,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* Make README.md file a required file for a package. [#287](https://github.com/elastic/integrations-registry/pull/287)
* Add stream fields to each dataset [#296](https://github.com/elastic/integrations-registry/pull/296)
* Add `all` query param to return all packages. By default is set false. [#301](https://github.com/elastic/integrations-registry/pull/301)
* Add `multiple` config for datasource. By default true. [#](https://github.com/elastic/integrations-registry/pull/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: missing reference to PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@ruflin ruflin merged commit daeab6b into elastic:master Apr 22, 2020
@ruflin ruflin deleted the multi-flag branch April 22, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants