Use config for cache times instead of hardcoding #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cache times are now also specified as time.Duration.
ruflin
requested review from
mtojek and
1stvamp
and removed request for
1stvamp
mtojek
approved these changes
Mar 18, 2020
There was a problem hiding this comment.
Not blocking at the moment, but I had to look deeper in the code to see the whole flow. I think there might a be a bug around an error path.
Consider a following scenario. The user hits /search endpoint, but the service is temporarily down (couple of secs). If the browser caches an error, it will last 10 minutes, until it's back to normal. I believe cache headers should be applied on happy path only.
ruflin
added a commit
to ruflin/package-registry
that referenced
this pull request
Mar 18, 2020
Based on elastic#271 (review) in the error case, we should not send any cache headers for the error pages.
mtojek
approved these changes
Mar 18, 2020
ruflin
added a commit
that referenced
this pull request
Mar 18, 2020
Based on #271 (review) in the error case, we should not send any cache headers for the error pages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache times are now also specified as time.Duration.