Add missing assets from datasets #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code was only going 4 levels deep when looking for assets. But since we introduce datasets more level exists. This code makes sure when the package output is generated it goes into all directories.
skh
reviewed
Nov 11, 2019
util/package.go
Outdated
| return err | ||
| var assets []string | ||
| var pattern = "*" | ||
| // Iterates 6 levels deep through the tree to find assets |
There was a problem hiding this comment.
Will there be a time when 6 levels aren't deep enough? Is there a way to solve this recursively once and for all?
There was a problem hiding this comment.
I'm sure it will happen. There is a library that does it but I was hesitant to include it here: https://github.com/bmatcuk/doublestar I'm just thinking of an alternative recursive implementation now that I mention it which "should" always work. Will update.
|
@skh I just pushed a new commit to make it recursive. Let me know what you think. |
skh
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code was only going 4 levels deep when looking for assets. But since we introduce datasets more level exists. This code makes sure when the package output is generated it goes into all directories.
Tests were updated with the new package format to also confirm this change.