Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .dockerignore file for slimmer image #104

Merged
merged 2 commits into from
Sep 11, 2019
Merged

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Sep 11, 2019

Adding the same files to .dockerignore as we had in the .gitignore files as these are not needed to build the container. This should make sure if a container is built locally but some of the .gitignore files are modified, it still builds to container. With this, less unncessary files should end up in the container.

Adding the same files to .dockerignore as we had in the .gitignore files as these are not needed to build the container. This should make sure if a container is built locally but some of the .gitignore files are modified, it still builds to container. With this, less unncessary files should end up in the container.
@ruflin ruflin requested review from skh and jfsiii September 11, 2019 11:16
Copy link

@jfsiii jfsiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per

@@ -0,0 +1,3 @@
.idea
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps .DS_Store as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, also added now integrations-registry. Seems like I did a bad copy of the .gitignore file.

@ruflin ruflin merged commit 29dbf7c into elastic:master Sep 11, 2019
@ruflin ruflin deleted the docker-ignore branch September 11, 2019 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants