Metricbeat improvements

[mdelapenya]

After testing the Helm chart for metricbeat in cooperation with the Integrations team (thank you @ChrsMark), we detected the following list of items to be updated in the chart:

• Remove in_cluster from add_kubernetes_metadata (partially removed here):
  • Value:

    helm-charts/metricbeat/values.yaml

    Line 25 in a03b78e

    in_cluster: true

  • Examples:

    helm-charts/metricbeat/examples/security/values.yaml

    Line 22 in a03b78e

    in_cluster: true

• livenessProbe:

  helm-charts/metricbeat/values.yaml

  Line 118 in a03b78e

  curl --fail 127.0.0.1:5066

  Check that the internal metrics endpoint (127.0.0.1:5066) is available. The official docs says it's disabled by default for security reasons.
• clusterRoleRules: Rules are not in sync (i.e. statefulsets are missing, nodes/stats only accepts get as verb)
  • Helm chart:

    helm-charts/metricbeat/values.yaml

    Lines 143 to 159 in a03b78e

    	clusterRoleRules:
    	- apiGroups:
    	- "extensions"
    	- "apps"
    	- ""
    	resources:
    	- namespaces
    	- pods
    	- events
    	- deployments
    	- nodes
    	- nodes/stats
    	- replicasets
    	verbs:
    	- get
    	- list
    	- watch

• Metricbeat reference: https://github.com/elastic/beats/blob/7.6/deploy/kubernetes/metricbeat-kubernetes.yaml#L320-L348

It's important to notice that also the Kubernetes operator has examples with different configurations

cc/ @jmlrt

[jmlrt]

• livenessProbe:

  helm-charts/metricbeat/values.yaml

  Line 118 in a03b78e

  curl --fail 127.0.0.1:5066

  Check that the internal metrics endpoint (127.0.0.1:5066) is available. The official docs says it's disabled by default for security reasons.

@mdelapenya HTTP endpoint is configured here: https://github.com/elastic/helm-charts/blob/master/metricbeat/templates/daemonset.yaml#L101

Can you confirm that's OK?

[mdelapenya]

Yeah, I'd say that that configuration enables the endpoint in that specific port.

Thanks!