-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logs compliance with ESC (errors and hash fields) #358
Comments
@juliocamarero Can you give us the complete document? I want to make sure we have the correct source. |
Sure @ph, here are the logs logs.tar.gz You can also see this other issue in those: #305 |
how do we check for log compliance at dev time / automated tests? we may have tools i'm unaware of, would like to know more. UPDATE: I'll ask the Engineering Productivity group to see what we collectively may know. |
fat fingered my keystrokes - didn't mean to close this. re-opening, sorry. |
Actually - I'm reviewing and we have a fix backported to 7.13... it will be in the build by tonight, so testable as a snapshot in cloud-staging or on cloud-qa (I think?) tomorrow, 5/18 - let's close it out to reduce the blocker's list for clarity's sake |
In
7.13
the logs claim to be ECS compliant but these two fields are not following ECS:The
error
according to ECE 1.8.0 should be an object, not a string (docs). The fieldhash
should also be an object (docs).cc @scunningham
The text was updated successfully, but these errors were encountered: