Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logs compliance with ESC (errors and hash fields) #358

Closed
juliocamarero opened this issue May 17, 2021 · 5 comments
Closed

Fix logs compliance with ESC (errors and hash fields) #358

juliocamarero opened this issue May 17, 2021 · 5 comments
Assignees
Labels
bug Something isn't working Team:Elastic-Agent Label for the Agent team v7.13.0

Comments

@juliocamarero
Copy link
Member

juliocamarero commented May 17, 2021

In 7.13 the logs claim to be ECS compliant but these two fields are not following ECS:

"ecs": {
   "version": "1.8.0"
},
"error": "context canceled",
"hash": "81b3d070dddec145fafcbdfb6f22888495a12edc31881f6b0511fa10de66daa7",

The error according to ECE 1.8.0 should be an object, not a string (docs). The field hash should also be an object (docs).

cc @scunningham

@ruflin ruflin added bug Something isn't working Team:Elastic-Agent Label for the Agent team v7.13.0 labels May 17, 2021
@ph
Copy link
Contributor

ph commented May 17, 2021

@juliocamarero Can you give us the complete document? I want to make sure we have the correct source.

@juliocamarero
Copy link
Member Author

Sure @ph, here are the logs logs.tar.gz

You can also see this other issue in those: #305

@EricDavisX
Copy link
Contributor

EricDavisX commented May 17, 2021

how do we check for log compliance at dev time / automated tests? we may have tools i'm unaware of, would like to know more.

UPDATE: I'll ask the Engineering Productivity group to see what we collectively may know.

@EricDavisX
Copy link
Contributor

EricDavisX commented May 17, 2021

fat fingered my keystrokes - didn't mean to close this. re-opening, sorry.

@EricDavisX
Copy link
Contributor

Actually - I'm reviewing and we have a fix backported to 7.13... it will be in the build by tonight, so testable as a snapshot in cloud-staging or on cloud-qa (I think?) tomorrow, 5/18 - let's close it out to reduce the blocker's list for clarity's sake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Team:Elastic-Agent Label for the Agent team v7.13.0
Projects
None yet
Development

No branches or pull requests

5 participants