Load limit presets should not overlap on max agents

[joshdover]

Our presets currently overlap by 1 which ends up in having unexpected behavior if you configure max agents to a value like 30000. In this case you'll end up using the 12,500 - 30,000 presets rather than the >= 30000 preset:

Using system limits for 12500 to 30000 agents for a configured value of 30000 agents

You can see how the bug presents itself:

• 12.5k preset has a max of 30k:

  fleet-server/internal/pkg/config/defaults/gt12500_limits.yml

  Line 3 in 0181e48

  max: 30000

• > 30k preset has a min of 30k:

  fleet-server/internal/pkg/config/defaults/max_limits.yml

  Line 2 in 0181e48

  min: 30000

• The code that iterates through these to choose a preset:

  fleet-server/internal/pkg/config/env_defaults.go

  Line 181 in 5b1c0df

  if l.Agents.Min < agentLimit && agentLimit <= l.Agents.Max {

This is sort of related to:

• custom server.limit values are not used  #1841

[joshdover]

For now we could probably solve this easily by just changing the min on each preset to be one less than the max on the next preset

[blakerouse]

I am working on #1841, I will take this one as well.

[blakerouse]

I went with lowering the max by 1 in each default. That way if the number is 30000 you get the higher limits.

[jlind23]

I went with lowering the max by 1 in each default. That way if the number is 30000 you get the higher limits.
@blakerouse is this something you have done already?

Otherwise I created a PR