From 926836e6002927829a1ef8833900cbf5e872df53 Mon Sep 17 00:00:00 2001 From: miukimiu Date: Mon, 26 Apr 2021 20:20:10 +0100 Subject: [PATCH 01/10] Making app icons to inherit parent color when nested in specific components --- CHANGELOG.md | 1 + .../badge/__snapshots__/badge.test.tsx.snap | 3 + src/components/badge/badge.tsx | 2 + .../badge/beta_badge/beta_badge.tsx | 1 + .../collapsed_item_actions.test.tsx.snap | 1 + .../in_memory_table.test.tsx.snap | 6 ++ .../button/__snapshots__/button.test.tsx.snap | 3 + .../button_content.test.tsx.snap | 2 + src/components/button/button_content.tsx | 7 +- .../__snapshots__/button_empty.test.tsx.snap | 3 + .../__snapshots__/button_group.test.tsx.snap | 84 +++++++++++++++++++ .../__snapshots__/button_icon.test.tsx.snap | 21 +++++ .../button/button_icon/button_icon.tsx | 1 + src/components/call_out/call_out.tsx | 1 + .../__snapshots__/card_select.test.tsx.snap | 1 + .../__snapshots__/code_block.test.tsx.snap | 2 + .../collapsible_nav.test.tsx.snap | 8 ++ .../context_menu/context_menu_item.tsx | 7 +- .../__snapshots__/data_grid.test.tsx.snap | 39 +++++++++ .../__snapshots__/filter_button.test.tsx.snap | 1 + .../flyout/__snapshots__/flyout.test.tsx.snap | 14 ++++ .../field_password.test.tsx.snap | 3 + .../__snapshots__/super_select.test.tsx.snap | 6 ++ .../icon/__snapshots__/icon.test.tsx.snap | 2 +- src/components/icon/_variables.scss | 1 + src/components/icon/icon.tsx | 7 +- .../__snapshots__/list_group.test.tsx.snap | 4 + .../list_group_item.test.tsx.snap | 4 + src/components/list_group/list_group_item.tsx | 8 +- .../pinnable_list_group.test.tsx.snap | 12 +++ .../markdown_editor.test.tsx.snap | 55 ++++++++++++ .../__snapshots__/confirm_modal.test.tsx.snap | 2 + .../modal/__snapshots__/modal.test.tsx.snap | 1 + .../notification_event.test.tsx.snap | 2 + ...tification_event_read_button.test.tsx.snap | 2 + .../__snapshots__/pagination.test.tsx.snap | 2 + .../selectable_list_item.test.tsx.snap | 1 + .../__snapshots__/side_nav.test.tsx.snap | 8 ++ .../__snapshots__/suggest_item.test.tsx.snap | 5 ++ src/components/suggest/suggest_item.tsx | 5 +- .../table_sort_mobile.test.tsx.snap | 1 + .../table_sort_mobile_item.test.tsx.snap | 1 + .../table_pagination.test.tsx.snap | 5 ++ 43 files changed, 338 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 30837482d3b..6e87ff16db2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ **Bug fixes** - Fixed missing i18n tokens for `EuiFilePicker` ([#4750](https://github.com/elastic/eui/pull/4750)) +- Fixed a bug in `EuiIcon` where app icons were getting two-tone colors when nested in specific components ([#4750](https://github.com/elastic/eui/pull/4750)) ## [`32.2.0`](https://github.com/elastic/eui/tree/v32.2.0) diff --git a/src/components/badge/__snapshots__/badge.test.tsx.snap b/src/components/badge/__snapshots__/badge.test.tsx.snap index bd6e2b78737..86874c2eaef 100644 --- a/src/components/badge/__snapshots__/badge.test.tsx.snap +++ b/src/components/badge/__snapshots__/badge.test.tsx.snap @@ -309,6 +309,7 @@ exports[`EuiBadge props iconSide left is rendered 1`] = ` @@ -330,6 +331,7 @@ exports[`EuiBadge props iconSide right is rendered 1`] = ` @@ -351,6 +353,7 @@ exports[`EuiBadge props iconType is rendered 1`] = ` diff --git a/src/components/badge/badge.tsx b/src/components/badge/badge.tsx index 424777cb8f0..c38091a37d9 100644 --- a/src/components/badge/badge.tsx +++ b/src/components/badge/badge.tsx @@ -261,6 +261,7 @@ export const EuiBadge: FunctionComponent = ({ size="s" {...closeButtonProps} className={closeClassNames} + color="default" // forces app icons to inherit de parent color /> ); @@ -270,6 +271,7 @@ export const EuiBadge: FunctionComponent = ({ type={iconType} size={children ? 's' : 'm'} className="euiBadge__icon" + color="default" // forces app icons to inherit de parent color /> ); } diff --git a/src/components/badge/beta_badge/beta_badge.tsx b/src/components/badge/beta_badge/beta_badge.tsx index 295efb4baaf..abf8eb85087 100644 --- a/src/components/badge/beta_badge/beta_badge.tsx +++ b/src/components/badge/beta_badge/beta_badge.tsx @@ -103,6 +103,7 @@ export const EuiBetaBadge: FunctionComponent = ({ type={iconType} size="m" aria-hidden="true" + color="default" // forces app icons to inherit de parent color /> ); } diff --git a/src/components/basic_table/__snapshots__/collapsed_item_actions.test.tsx.snap b/src/components/basic_table/__snapshots__/collapsed_item_actions.test.tsx.snap index 40a0fae8a90..3eb101a179f 100644 --- a/src/components/basic_table/__snapshots__/collapsed_item_actions.test.tsx.snap +++ b/src/components/basic_table/__snapshots__/collapsed_item_actions.test.tsx.snap @@ -20,6 +20,7 @@ exports[`CollapsedItemActions render 1`] = `