From b89df2e18ccd51b1c94fb4118b60fe667835b3e4 Mon Sep 17 00:00:00 2001 From: miukimiu Date: Fri, 4 Dec 2020 18:14:16 +0000 Subject: [PATCH 1/4] Prevented popover to open when empty array is passed into suggestions prop --- src/components/suggest/suggest_input.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/suggest/suggest_input.tsx b/src/components/suggest/suggest_input.tsx index 0beb78e14d5..3781ada7642 100644 --- a/src/components/suggest/suggest_input.tsx +++ b/src/components/suggest/suggest_input.tsx @@ -150,7 +150,7 @@ export const EuiSuggestInput: FunctionComponent = ( 0 && isPopoverOpen} panelPaddingSize="none" fullWidth closePopover={closePopover}> From 2d4997720aacb66e2faa3de6e9f3055c36834e8b Mon Sep 17 00:00:00 2001 From: miukimiu Date: Fri, 4 Dec 2020 18:23:58 +0000 Subject: [PATCH 2/4] Adding CL --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5a8cc48e6a6..1fc1959e3fe 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ - Fixed `EuiErrorBoundary` error message not showing in non-Chromium browsers ([#4324](https://github.com/elastic/eui/pull/4324)) - Fixed `EuiToolTip` closing during initial positioning period ([#4327](https://github.com/elastic/eui/pull/4327)) - Added `!default` to SASS variables of `EuiCollapsibleNav` ([#4335](https://github.com/elastic/eui/pull/4335)) +- Prevented `EuiSuggest` popover to open when an empty array is passed into `suggestions` prop ([#4349](https://github.com/elastic/eui/pull/4349)) **Theme: Amsterdam** From 715d2e0a476dc5bd30418f79f43a004e32193e8d Mon Sep 17 00:00:00 2001 From: Elizabet Oliveira Date: Wed, 9 Dec 2020 17:50:40 +0000 Subject: [PATCH 3/4] Update src/components/suggest/suggest_input.tsx Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> --- src/components/suggest/suggest_input.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/suggest/suggest_input.tsx b/src/components/suggest/suggest_input.tsx index 3781ada7642..d26a70c2713 100644 --- a/src/components/suggest/suggest_input.tsx +++ b/src/components/suggest/suggest_input.tsx @@ -150,7 +150,7 @@ export const EuiSuggestInput: FunctionComponent = ( 0 && isPopoverOpen} + isOpen={suggestions.length && isPopoverOpen} panelPaddingSize="none" fullWidth closePopover={closePopover}> From d5905b3e616ce51e5de3095996830caacfbaa7ee Mon Sep 17 00:00:00 2001 From: Elizabet Oliveira Date: Wed, 9 Dec 2020 17:51:07 +0000 Subject: [PATCH 4/4] Update CHANGELOG.md Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1fc1959e3fe..dfa4bd41cd2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,7 +8,7 @@ - Fixed `EuiErrorBoundary` error message not showing in non-Chromium browsers ([#4324](https://github.com/elastic/eui/pull/4324)) - Fixed `EuiToolTip` closing during initial positioning period ([#4327](https://github.com/elastic/eui/pull/4327)) - Added `!default` to SASS variables of `EuiCollapsibleNav` ([#4335](https://github.com/elastic/eui/pull/4335)) -- Prevented `EuiSuggest` popover to open when an empty array is passed into `suggestions` prop ([#4349](https://github.com/elastic/eui/pull/4349)) +- Fixed `EuiSuggest` popover opening when an empty array is passed into the `suggestions` prop ([#4349](https://github.com/elastic/eui/pull/4349)) **Theme: Amsterdam**