From fbcd8dca2cce9a62814d8bb7317ec11af434ce86 Mon Sep 17 00:00:00 2001 From: miukimiu Date: Tue, 27 Oct 2020 19:12:10 +0000 Subject: [PATCH 1/3] Removing EuiButtonGroup unnecessary shadow --- CHANGELOG.md | 1 + .../button/button_group/_button_group.scss | 12 +----------- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index fd1878886e0..4cc7469fb30 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ - Fixed issue with duplicate checkmarks in `EuiComboBox` ([#4162](https://github.com/elastic/eui/pull/4162)) - Reinstated base element type extensions for `EuiStepHorizontal` and `EuiStepsHorizontal` ([4166](https://github.com/elastic/eui/pull/4166)) +- Removed unnecessary shadow on hover of `EuiButtonGroup` ([#000](https://github.com/elastic/eui/pull/000)) ## [`30.0.0`](https://github.com/elastic/eui/tree/v30.0.0) diff --git a/src/components/button/button_group/_button_group.scss b/src/components/button/button_group/_button_group.scss index f7b2bcc191b..4057b07151b 100644 --- a/src/components/button/button_group/_button_group.scss +++ b/src/components/button/button_group/_button_group.scss @@ -22,20 +22,10 @@ display: flex; overflow: hidden; transition: all $euiAnimSpeedNormal ease-in-out; - - &:hover, - &:active, - &:focus-within { - @include euiSlightShadowHover; - } } .euiButtonGroup--isDisabled .euiButtonGroup__buttons { - &:hover, - &:active, - &:focus-within { - box-shadow: none !important; // sass-lint:disable-line no-important - } + box-shadow: none; } .euiButtonGroup--compressed { From 4aa5fa6f1589ed7d791722b7b930668a4b810029 Mon Sep 17 00:00:00 2001 From: miukimiu Date: Tue, 27 Oct 2020 19:29:57 +0000 Subject: [PATCH 2/3] Adding CL number --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4cc7469fb30..3147cee08d0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,7 +10,7 @@ - Fixed issue with duplicate checkmarks in `EuiComboBox` ([#4162](https://github.com/elastic/eui/pull/4162)) - Reinstated base element type extensions for `EuiStepHorizontal` and `EuiStepsHorizontal` ([4166](https://github.com/elastic/eui/pull/4166)) -- Removed unnecessary shadow on hover of `EuiButtonGroup` ([#000](https://github.com/elastic/eui/pull/000)) +- Removed unnecessary shadow on hover of `EuiButtonGroup` ([#4186](https://github.com/elastic/eui/pull/4186)) ## [`30.0.0`](https://github.com/elastic/eui/tree/v30.0.0) From 48b2b43880dccd5d12cef988146ebb1abe6a1de2 Mon Sep 17 00:00:00 2001 From: miukimiu Date: Wed, 28 Oct 2020 14:48:50 +0000 Subject: [PATCH 3/3] Moving CL entry to master --- CHANGELOG.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 54adf8b52bc..f9690ec1f1b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,10 @@ - Added more exports for `EuiInMemoryTable` types ([#4179](https://github.com/elastic/eui/pull/4179)) +**Bug fixes** + +- Removed unnecessary shadow on hover of `EuiButtonGroup` ([#4186](https://github.com/elastic/eui/pull/4186)) + ## [`30.1.0`](https://github.com/elastic/eui/tree/v30.1.0) - Improved `EuiButtonGroup` focus, hover, selected and disabled states ([#4142](https://github.com/elastic/eui/pull/4142)) @@ -14,7 +18,6 @@ - Fixed issue with duplicate checkmarks in `EuiComboBox` ([#4162](https://github.com/elastic/eui/pull/4162)) - Reinstated base element type extensions for `EuiStepHorizontal` and `EuiStepsHorizontal` ([4166](https://github.com/elastic/eui/pull/4166)) -- Removed unnecessary shadow on hover of `EuiButtonGroup` ([#4186](https://github.com/elastic/eui/pull/4186)) ## [`30.0.0`](https://github.com/elastic/eui/tree/v30.0.0)