From e96e489d868ef4619b73182a17db6b2f358a6b12 Mon Sep 17 00:00:00 2001 From: Anish Aggarwal Date: Mon, 24 Feb 2020 19:28:25 +0530 Subject: [PATCH 1/2] removed duplicate icons --- CHANGELOG.md | 1 + src-docs/src/views/icon/icons.js | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5fd3032ce3d..16e762c5cc0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,6 @@ ## [`master`](https://github.com/elastic/eui/tree/master) +- Removed Duplicate Icons from docs ([#2836](https://github.com/elastic/eui/pull/2836)) - Converted `EuiCodeEditor` to Typescript ([#2836](https://github.com/elastic/eui/pull/2836)) - Converted `EuiCode` and `EuiCodeBlock` and to Typescript ([#2835](https://github.com/elastic/eui/pull/2835)) - Converted `EuiFilePicker` to TypeScript ([#2832](https://github.com/elastic/eui/issues/2832)) diff --git a/src-docs/src/views/icon/icons.js b/src-docs/src/views/icon/icons.js index de9f2b8f637..a462c769bf7 100644 --- a/src-docs/src/views/icon/icons.js +++ b/src-docs/src/views/icon/icons.js @@ -201,10 +201,8 @@ export const iconTypes = [ 'visBarHorizontalStacked', 'visBarVertical', 'visBarVerticalStacked', - 'visControls', 'visGauge', 'visGoal', - 'visHeatmap', 'visLine', 'visMapCoordinate', 'visMapRegion', From 42dd665d449dc2c198b1af4987a2ea5be344ef34 Mon Sep 17 00:00:00 2001 From: Caroline Horn <549577+cchaos@users.noreply.github.com> Date: Mon, 24 Feb 2020 11:27:33 -0500 Subject: [PATCH 2/2] Fixing changelog and updating tests (#1) --- CHANGELOG.md | 5 ++- .../icon/__snapshots__/icon.test.tsx.snap | 34 ------------------- 2 files changed, 4 insertions(+), 35 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8d66962490f..b8e5fa4dbd4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,10 @@ - Fixed building dev & docs on Windows ([#2847](https://github.com/elastic/eui/pull/2847)) - Fixed a bug in `EuiDataGrid` causing the first cell to autofocus if interactive ([#2872](https://github.com/elastic/eui/pull/2872)) +**Breaking changes** + +- Removed `visControls` and `visHeatmap` duplicate icons from docs ([#2908](https://github.com/elastic/eui/pull/2908)) + ## [`19.0.0`](https://github.com/elastic/eui/tree/v19.0.0) - Added `cheer` glyph to `EuiIcon` ([#2814](https://github.com/elastic/eui/pull/2814)) @@ -46,7 +50,6 @@ **Breaking changes** -- Removed `visControls` and `visHeatmap` duplicate icons from docs ([#2908](https://github.com/elastic/eui/pull/2908)) - Removed `idAria` prop from `EuiDescribedFormGroup` ([#2783](https://github.com/elastic/eui/pull/2783)) - Removed `EuiToken`'s `hideBorder` and `displayOptions` prop for applying `color`, `shape`, and `fill` props directly. Changed `fill` prop type from `boolean` to `light | dark | none`. ([#2758](https://github.com/elastic/eui/pull/2758)) diff --git a/src/components/icon/__snapshots__/icon.test.tsx.snap b/src/components/icon/__snapshots__/icon.test.tsx.snap index f60a8d6b9c8..01f39c8c6d5 100644 --- a/src/components/icon/__snapshots__/icon.test.tsx.snap +++ b/src/components/icon/__snapshots__/icon.test.tsx.snap @@ -8239,23 +8239,6 @@ exports[`EuiIcon props type visBarVerticalStacked is rendered 1`] = ` `; -exports[`EuiIcon props type visControls is rendered 1`] = ` - -`; - exports[`EuiIcon props type visGauge is rendered 1`] = `