Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiComboBox converts entered text into a custom option on blur #1353

Merged
merged 5 commits into from
Dec 7, 2018
Merged

EuiComboBox converts entered text into a custom option on blur #1353

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b07b121
`EuiComboBox` will convert entered text into a custom option when the…
cjcenizal Dec 6, 2018
66772c4
Changelog.
cjcenizal Dec 6, 2018
7fb4955
Changelog.
cjcenizal Dec 7, 2018
c6bbffa
Merge remote-tracking branch 'upstream/master' into combo-box-add-inp…
cjcenizal Dec 7, 2018
aedd057
Bad, merge resolution! Bad.
cjcenizal Dec 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
- Altered functionality of `truncate` on `EuiBreadcrumbs` and added `truncate` ability on breadcrumb item ([#1346](https://github.com/elastic/eui/pull/1346))
- Altered `EuiHeader`'s location of `EuiHeaderBreadcrumbs` based on the new `truncate` ability ([#1346](https://github.com/elastic/eui/pull/1346))
- Added support for `href` and `target` props in `EuiBasicTable` actions ([#1347](https://github.com/elastic/eui/pull/1347))
- `EuiComboBox` will convert entered text into a custom option when the user takes away focus, e.g. by tabbing to another element. This prevents the `EuiComboBox` from being mistaken for a `EuiInputText`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can turn this into an "Added support for..." entry.


## [`5.4.0`](https://github.com/elastic/eui/tree/v5.4.0)

Expand Down
6 changes: 6 additions & 0 deletions src/components/combo_box/combo_box.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,12 @@ export class EuiComboBox extends Component {
this.closeList();
}

// If the user tabs away or changes focus to another element, take whatever input they've
// typed and convert it into a pill, to prevent the combo box from looking like a text input.
if (!this.hasActiveOption()) {
this.addCustomOption();
}

if (this.props.onBlur) {
this.props.onBlur(e);
}
Expand Down