-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new icon (Add chart breakdown) to library #8121
Comments
Thanks for opening this issue, @patpscal! I think this icon looks good. My only concern is that it may be interpreted as "add bar chart" instead of the desired "breakdown" action. Have you given any consideration to using our existing CCing my fellow analytics nerds in the @elastic/platform-design team, in case they have any thoughts as well. |
I think using the existing icon (sans plus) makes sense for a couple of additional reasons:
Given these considerations, even if hypothetical, we may as well save the extra work and roll with the |
Thank you for your insights, @MichaelMarcialis and @ryankeairns. Since the popover may change, we'll proceed with |
From Logs+, we want to add an icon to the library.
As discussed here: elastic/kibana#192700 (comment: elastic/kibana#192700 (comment)), it represents a new functionality for Discover fields, conveying that executing the button will add the selected field as a breakdown to the main bar chart.
I used the "plus" symbol in a bar chart to clarify that we are adding the field to an existing visualization instead of opening a visualization builder.
Please let me know what you think. If you're OK with this addition, I'll prepare the PR :)
The text was updated successfully, but these errors were encountered: