Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add padding to mobile nav menu #7947

Closed
ryankeairns opened this issue Aug 6, 2024 · 3 comments · Fixed by #7961
Closed

Add padding to mobile nav menu #7947

ryankeairns opened this issue Aug 6, 2024 · 3 comments · Fixed by #7961

Comments

@ryankeairns
Copy link
Contributor

Describe the bug
Looks like we might have lost some padding in the mobile nav.

From EUI docs
CleanShot 2024-08-06 at 10 08 42@2x

From Kibana > Discover
CleanShot 2024-08-06 at 10 17 50@2x

Impact and severity
The impact and severity are likely to be low as we see low, single-digit use on smaller viewports. That said, we don't know who/how this is used outside of our walls.

Environment and versions

  • EUI version:
  • React version:
  • Kibana version (if applicable): main branch (8.16)
  • Browser: arc
  • Operating System: mac

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://eui.elastic.co/#/layout/header/elastic-pattern and open the 'Fullscreen demo' or run Kibana locally and open Discover with a small viewport

Expected behavior
Padding within the panel... something like:
CleanShot 2024-08-06 at 10 20 43@2x

Minimum reproducible sandbox
It is extremely helpful for us if you are able to reproduce your issue in a minimum reproducible sandbox (visit our docs site and click the CodeSandbox logo in the top-right corner).

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@ryankeairns ryankeairns added bug ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible labels Aug 6, 2024
@cee-chen
Copy link
Contributor

cee-chen commented Aug 7, 2024

@ryankeairns it looks like the lack of padding has been the case / intentional since the inception of the component: https://eui.elastic.co/v40.0.0/#/layout/header/elastic-pattern

If we'd like to change it, that's fine, but at that point EuiButtonEmptys may look a tad odd and like they have too much spacing.

@cee-chen cee-chen added feature request design decision and removed bug ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible labels Aug 7, 2024
@cee-chen
Copy link
Contributor

@ryankeairns just to confirm, do you want to go ahead and add the padding (with a note that EuiButtonEmptys may then look very spaced out?)

@ryankeairns
Copy link
Contributor Author

Hey, apologies, I was out. I would vote for adding the padding as it will result in a nicer default than how it looks today... even if still imperfect. ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants