[React 18] Docs issues follow-up

[cee-chen]

Page template jumping

Page template padding offset is lost and then restored on route navigation, leading to the page title jumping like below:

Sidenav scroll 'memory' is lost

Previous React 17 behavior - clicked links scroll into view in the center of the nav:

React 18 behavior - scroll behavior is completely lost:

The current scroll behavior requires a timeout of ~100ms to restore properly, which leads to visual jank on page navigation:

[cee-chen]

Cross-posting my thoughts in Slack for (maybe) helpfulness:

I could be wrong, but it feels like in React 17, our components didn't fully rerender between pages (which is the whole point of SPAs, imo) but now on in React 18, when a route changes, everything on the page is fully unmounting and remounting which is causing a bunch of visual jank

What I'm trying to figure out is if this is either 1. directly caused by React 18 changes, or 2. related to the React Router changes we made as part of the react 18 upgrade