Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiInMemoryTable] EuiSearchBar does not toggle selected value when filters are set to multiSelect: false #6540

Closed
robert-seymour-numerated opened this issue Jan 23, 2023 · 4 comments · Fixed by #6577
Labels

Comments

@robert-seymour-numerated
Copy link

robert-seymour-numerated commented Jan 23, 2023

Repro Steps

  • stackblitz
    • Select option 1
    • Select option 2 and see that both are deselected

Expected behavior

  • option 2 is selected and option 1 is deselected

My hunch is the diff const in this filter. I think that when multiselect=false the logic needs to pass the new checked option as opposed to just the removed one

@cee-chen
Copy link
Contributor

Hey @robert-seymour-numerated! Just as a heads up, your stackblitz link doesn't appear to have EUI in it / is linking to a generic setup. Maybe give CodeSandbox a shot instead?

Your hunch doesn't sound off the mark to me - would you be open to opening a PR against EuiSearchBar with a fix + unit tests?

@robert-seymour-numerated
Copy link
Author

@cee-chen Of course I forgot to hit that save button :( on the stackblitz, trying to re-create now haha. I can open a PR in the near future, but I don't have EUI locally set up at the moment

@robert-seymour-numerated
Copy link
Author

@cee-chen here is an actually saved Stackblitz. Apologies

@cee-chen cee-chen added the bug label Jan 23, 2023
@cee-chen
Copy link
Contributor

No worries at all! Thanks for the super easy to follow minimum reproducible code. I can confirm this bug/behavior.

As a heads up our team is somewhat small and our backlog is fairly large right now, so this is likely to be low priority for our team, but if you have the time or interest in helping out, we'd super welcome a PR! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants