Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiModal] Wrap EuiModalHeaderTitle in H1 unless an escape hatch prop is passed #6531

Closed
3 tasks
1Copenut opened this issue Jan 17, 2023 · 0 comments · Fixed by #6530
Closed
3 tasks

[EuiModal] Wrap EuiModalHeaderTitle in H1 unless an escape hatch prop is passed #6531

1Copenut opened this issue Jan 17, 2023 · 0 comments · Fixed by #6530

Comments

@1Copenut
Copy link
Contributor

Description

We've had a few reports of Kibana modal headers that have stopped rendering a proper H1 title. This regression is related to the following items:

During a Slack discussion with @cee-chen and @jen-huang we determined it would be worthwhile to automatically wrap the children prop with an H1 tag unless developers passed an escape hatch prop to render children exactly as they've written it.

WCAG guidance

Tasks

  • Write an escape hatch prop to add to EuiModalHeaderTitle logic for overriding the H1 wrapper for children
  • Add unit tests to evaluate standard modal, confirmation modal with and without H1 wrapper
  • Update the Confirm Modal documentation to provide awareness of this logic

Kibana confirmation modals with H1 not rendered
image


EUI Docs for Confirmation Modal
Screen Shot 2023-01-17 at 4 14 06 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant