[EuiModal] Wrap EuiModalHeaderTitle
in H1 unless an escape hatch prop is passed
#6531
Closed
3 tasks
Labels
accessibility - markup
accessibility - WCAG A
Level A WCAG Accessibility Criteria
accessibility
breaking change
Description
We've had a few reports of Kibana modal headers that have stopped rendering a proper H1 title. This regression is related to the following items:
EuiConfirmModal
calls for atitle
prop that's a React Node. This prop goes directly into the modal title header component and if it's a React Node, doesn't get the H1 wrapper.During a Slack discussion with @cee-chen and @jen-huang we determined it would be worthwhile to automatically wrap the
children
prop with an H1 tag unless developers passed an escape hatch prop to renderchildren
exactly as they've written it.WCAG guidance
Tasks
EuiModalHeaderTitle
logic for overriding the H1 wrapper forchildren
Kibana confirmation modals with H1 not rendered
EUI Docs for Confirmation Modal
The text was updated successfully, but these errors were encountered: