Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory table does not construct query correctly when filtering #6349

Closed
thomheymann opened this issue Nov 8, 2022 · 5 comments · Fixed by #6356
Closed

Memory table does not construct query correctly when filtering #6349

thomheymann opened this issue Nov 8, 2022 · 5 comments · Fixed by #6356
Assignees
Labels

Comments

@thomheymann
Copy link
Contributor

There is an issue with the way search bar queries are constructed when filtering in EuiMemoryTable component causing bugs when e.g. usernames or tags contain special characters: elastic/kibana#143079

Screenshot 2022-11-08 at 13 15 59

To fix this values that contain special characters should be wrapped in quotation marks, e.g.:

  • username:user@domain should be username:"user@domain" instead
  • tag:(tag1 or tag2@tag2) should be tag:(tag1 or "tag2@tag2") instead
@cee-chen
Copy link
Contributor

cee-chen commented Nov 8, 2022

@thomheymann can you clarify the urgency level of this bug? Is it something that needs to get in before 8.6FF?

@thomheymann
Copy link
Contributor Author

@thomheymann can you clarify the urgency level of this bug? Is it something that needs to get in before 8.6FF?

@constancecchen Would be great to have obviously but if there's more urgent issues 8.7 would be ok too I think.

@cee-chen
Copy link
Contributor

cee-chen commented Nov 9, 2022

FYI @chandlerprall

@chandlerprall
Copy link
Contributor

As long as the fix doesn't touch the query syntax parsing (doesn't sound like it will), if we can get a fix merged by EOD Thursday then a quick backport for 8.6 makes sense to me (I can run that & the Kibana update).

@cee-chen
Copy link
Contributor

touch the query syntax parsing (doesn't sound like it will)

I think it does (or at least that would be my preferred fix, personally, and to expand this fix to all special characters that don't have EQL meaning (e.g. not throwing on ~!@#$%^&; etc). Am I off on that?

PR for review: #6356

We're also getting real close to FF so I'm not totally sure we should try and squeeze this in, unless someone else wants to pick this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants