-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiPopover] Background in dark mode isn't different from the main background #5788
Comments
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error. |
This still seems valid. @miukimiu, do you mind responding? |
The The popover In dark mode, I have to agree it's hard to see the shadow. The contrast between the popover and the background it is not good. I think we need to introduce better design practices to solve this issue. For example, in Material Design Dark Mode higher elevation gets a lighter surface. I think this concept can solve our portal component's lack of contrast issues. I created a CodeSandbox exploring this concept (please ignore the arrows not getting the right color 😅 ): https://codesandbox.io/s/keen-sun-sdbh6t?file=/demo.js. Examples 3 and 4 use a lighter background.
@formgeist, let me know your thoughts. Do you agree with this approach? |
👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed. |
❌ Per our previous message, this issue is auto-closing after having been open and inactive for a year. If you strongly feel this is still a high-priority issue, or are interested in contributing, please leave a comment or open a new issue linking to this one for context. |
Re-opening as still valid. IMO, this would be a quick and easy fix for someone to grab (just changing the color of popovers, either via CSS or prop) |
Summary
In the many components that use
EuiPopover
for showing additional content, in dark mode the popover background blends completely with the background color and this makes the popover harder to distinguish.Examples
The text was updated successfully, but these errors were encountered: