Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiMarkdownEditor] Enhancement request: Smarter UI when no plugins present #5127

Closed
i-a-n opened this issue Sep 1, 2021 · 1 comment · Fixed by #5147
Closed

[EuiMarkdownEditor] Enhancement request: Smarter UI when no plugins present #5127

i-a-n opened this issue Sep 1, 2021 · 1 comment · Fixed by #5147

Comments

@i-a-n
Copy link
Contributor

i-a-n commented Sep 1, 2021

I notice after #4383 was merged, the markdown editor having zero UI plugins became a possibility; but the UI doesn't really handle that state gracefully:

Screen Shot 2021-09-01 at 1 39 52 PM

The language and the horizontal rules are now somewhat misleading and out of place. If we updated the UI logic to be a bit smarter I think it'd make for a nicer experience.

@elizabetdev
Copy link
Contributor

@chandlerprall we should also document better how to unregister plugins. It seems that @i-a-n found how to do it by reading this PR #4383:

https://github.com/elastic/dream-machine/blob/390d52ce81dcd1ac45727f64b992bd89763a1bb8/client/frontend/src/containers/CaseContainer/index.tsx#L610-L613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants