Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] core.euiFilterButton.filterBadge is setting hardcoded values #4786

Closed
afharo opened this issue May 10, 2021 · 4 comments
Closed

[i18n] core.euiFilterButton.filterBadge is setting hardcoded values #4786

afharo opened this issue May 10, 2021 · 4 comments
Assignees
@cee-chen
Labels
bug good first issue

Comments

@afharo
Copy link
Member

afharo commented May 10, 2021

The i18n label core.euiFilterButton.filterBadge receives a value filterCountLabel that is calculated depending on other value:

https://github.com/elastic/kibana/blob/5f618da802228025b8225ff36222d02c95708230/src/core/public/i18n/i18n_eui_mapping.tsx#L503-L507

The problem is that the hardcoded values are not localized.

I think we can fix that by referencing a new i18n.translate('core.euiFilterButton.filterBadgeActive', { defaultValue: 'active' }) and i18n.translate('core.euiFilterButton.filterBadgeAvailable', { defaultValue: 'available' })
@elasticmachine
Copy link
Collaborator

Pinging @elastic/kibana-design (Team:Kibana-Design)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/eui-design (EUI)

@cchaos cchaos transferred this issue from elastic/kibana May 10, 2021
@cee-chen cee-chen self-assigned this Aug 19, 2021
This was referenced Aug 19, 2021
Closed
Merged
@cee-chen
Copy link
Contributor

cee-chen commented Sep 9, 2021

Totally forgot to close this earlier, but this should have been addressed by #5061 and elastic/kibana#109926!

@cee-chen cee-chen closed this as completed Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cee-chen cee-chen

Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[EUI] Fix EuiFilterButton badge i18n cee-chen/kibana
4 participants
@cee-chen @cchaos @afharo @elasticmachine